Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752024AbbKYLTP (ORCPT ); Wed, 25 Nov 2015 06:19:15 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47992 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbbKYLTN (ORCPT ); Wed, 25 Nov 2015 06:19:13 -0500 Date: Wed, 25 Nov 2015 11:18:58 +0000 From: Mark Brown To: Richard Fitzgerald Cc: Takashi Iwai , vinod.koul@intel.com, alsa-devel@alsa-project.org, lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, perex@perex.cz, linux-kernel@vger.kernel.org Message-ID: <20151125111858.GO1929@sirena.org.uk> References: <1448448376-12880-1-git-send-email-rf@opensource.wolfsonmicro.com> <1448448376-12880-3-git-send-email-rf@opensource.wolfsonmicro.com> <1448449621.3536.48.camel@rf-debian.wolfsonmicro.main> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KM+e2hnYAO+MCJ5e" Content-Disposition: inline In-Reply-To: <1448449621.3536.48.camel@rf-debian.wolfsonmicro.main> X-Cookie: A beer delayed is a beer denied. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 2/2] ALSA: compress: Pass id string to snd_compress_new X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1549 Lines: 42 --KM+e2hnYAO+MCJ5e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 25, 2015 at 11:07:01AM +0000, Richard Fitzgerald wrote: > On Wed, 2015-11-25 at 11:49 +0100, Takashi Iwai wrote: > > > + if (IS_ENABLED(CONFIG_SND_VERBOSE_PROCFS)) > > This should be #if. Otherwise the compile would fail (as already > Builds ok for me, this will become if(false) if it's not enabled so the > compiler will strip it out - some maintainers prefer that to #if and I'm > used to being told to use this style instead of #if, so who knows what > today's coding style is :) The build bot failure was for a different > reason. The compiler will still spot syntax errors and similar in an if (false) section. --KM+e2hnYAO+MCJ5e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWVZkhAAoJECTWi3JdVIfQYMAH/RDpPAlAyOuhSw7lE9min1LH jSSY8NXvXb/OuuziIQ3F1AS8psV1C09Lb3DkrJZ3GNmx7qo+SRqBoN5i0T3Eoyzg X8TDGyCIJXFi32B5NlO/gSXLm2eKse0e+HzYEAm1nBS5opofAtXShQQ2KMPMsV5h /xfBkw0oTSyCQ18Rq8Z4ACyFxLM2VkpzRjZ4c4EJdxlZnxyyDsFOWUpq0UF+61JU iph4DYWaC2v8H/h87zD1fWUPt9gDbwwkn+7yOPxoH42ZnJGvj+wieicamoRUDqqd xfuTA3EAyUrUJWHNrq/KcyLcqDoP6XD59SPDd10ran2k11JY5ytXJT/VqvIW7jY= =mF0v -----END PGP SIGNATURE----- --KM+e2hnYAO+MCJ5e-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/