Date: Wed, 25 Nov 2015 03:22:13 -0800
From: Christoffer Dall <christoffer.dall@linaro.org>
To: Jin Qian <jinqian@android.com>
Cc: Greg Hackmann <ghackmann@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Jason Hu <jia-cheng.hu@intel.com>, Yu Ning <yu.ning@intel.com>,
        Joe Perches <joe@perches.com>,
        Peter Senna Tschudin <peter.senna@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] platform: goldfish: pipe: add devicetree bindings
Message-ID: <20151125112213.GB11346@lvm>
References: <1448413812-24289-1-git-send-email-jinqian@android.com>
 <1448413812-24289-5-git-send-email-jinqian@android.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1448413812-24289-5-git-send-email-jinqian@android.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1554
Lines: 44

On Tue, Nov 24, 2015 at 05:10:08PM -0800, Jin Qian wrote:
> From: Greg Hackmann <ghackmann@google.com>
> 
> Signed-off-by: Greg Hackmann <ghackmann@google.com>
> (cherry picked from commit 3c56d07eb796066530e93a40e74dea3bc59bf4cf)
> Signed-off-by: Jin Qian <jinqian@android.com>
> ---
>  drivers/platform/goldfish/goldfish_pipe.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
> index 20a9337..86cc57f 100644
> --- a/drivers/platform/goldfish/goldfish_pipe.c
> +++ b/drivers/platform/goldfish/goldfish_pipe.c
> @@ -624,11 +624,19 @@ static int goldfish_pipe_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static const struct of_device_id goldfish_pipe_of_match[] = {
> +	{ .compatible = "generic,android-pipe", },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, goldfish_pipe_of_match);
> +
>  static struct platform_driver goldfish_pipe = {
>  	.probe = goldfish_pipe_probe,
>  	.remove = goldfish_pipe_remove,
>  	.driver = {
> -		.name = "goldfish_pipe"
> +		.name = "goldfish_pipe",
> +		.owner = THIS_MODULE,
> +		.of_match_table = goldfish_pipe_of_match,
>  	}
>  };
>  
I think this needs something documented in
Documentation/devicetree/bindings as well.

-Christoffer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/