Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752852AbbKYL34 (ORCPT ); Wed, 25 Nov 2015 06:29:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:57999 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752556AbbKYL3x (ORCPT ); Wed, 25 Nov 2015 06:29:53 -0500 Date: Wed, 25 Nov 2015 11:29:50 +0000 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: fix swapped Movable and Reclaimable in /proc/pagetypeinfo Message-ID: <20151125112949.GQ19677@suse.de> References: <1448295734-14072-1-git-send-email-vbabka@suse.cz> <1448297590-19088-1-git-send-email-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1448297590-19088-1-git-send-email-vbabka@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1326 Lines: 32 On Mon, Nov 23, 2015 at 05:53:10PM +0100, Vlastimil Babka wrote: > Commit 016c13daa5c9 ("mm, page_alloc: use masks and shifts when converting GFP > flags to migrate types") has swapped MIGRATE_MOVABLE and MIGRATE_RECLAIMABLE > in the enum definition. However, migratetype_names wasn't updated to reflect > that. As a result, the file /proc/pagetypeinfo shows the counts for Movable as > Reclaimable and vice versa. > > Additionally, commit 0aaa29a56e4f ("mm, page_alloc: reserve pageblocks for > high-order atomic allocations on demand") introduced MIGRATE_HIGHATOMIC, but > did not add a letter to distinguish it into show_migration_types(), so it > doesn't appear in the listing of free areas during page alloc failures or oom > kills. > > This patch fixes both problems. The atomic reserves will show with a letter > 'H' in the free areas listings. > > Fixes: 016c13daa5c9e4827eca703e2f0621c131f2cca3 > Fixes: 0aaa29a56e4fb0fc9e24edb649e2733a672ca099 > Signed-off-by: Vlastimil Babka Thanks Acked-by: Mel Gorman -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/