Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994AbbKYMAJ (ORCPT ); Wed, 25 Nov 2015 07:00:09 -0500 Received: from mx2.suse.de ([195.135.220.15]:60166 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbbKYMAI (ORCPT ); Wed, 25 Nov 2015 07:00:08 -0500 Message-ID: <1448452806.2877.75.camel@suse.de> Subject: Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource From: Johannes Thumshirn To: Ching Huang Cc: hch@lst.de, hch@infradead.org, thenzl@redhat.com, jbottomley@parallels.com, dan.carpenter@oracle.com, agordeev@redhat.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hare@suse.de Date: Wed, 25 Nov 2015 13:00:06 +0100 In-Reply-To: <1448451683.4670.35.camel@Centos6.3-64> References: <1448451683.4670.35.camel@Centos6.3-64> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1566 Lines: 46 On Wed, 2015-11-25 at 19:41 +0800, Ching Huang wrote: > From: Ching Huang > > Releasing allocated resource if get configuration data failed. > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c > b/drivers/scsi/arcmsr/arcmsr_hba.c > --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-24 11:35:26.000000000 > +0800 > +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-25 19:04:44.590970000 > +0800 > @@ -2664,7 +2664,7 @@ static bool arcmsr_hbaB_get_config(struc >   if (!arcmsr_hbaB_wait_msgint_ready(acb)) { >   printk(KERN_NOTICE "arcmsr%d: wait 'get adapter firmware \ >   miscellaneous data' timeout \n", acb->host- > >host_no); > - return false; > + goto err_free_dma; >   } >   count = 8; >   while (count){ > @@ -2707,6 +2707,10 @@ static bool arcmsr_hbaB_get_config(struc >   acb->firm_cfg_version = readl(®- > >message_rwbuffer[25]);  /*firm_cfg_version,25,100-103*/ >   /*firm_ide_channels,4,16-19*/ >   return true; > +err_free_dma: > + dma_free_coherent(&acb->pdev->dev, acb->roundup_ccbsize, > + acb->dma_coherent2, acb->dma_coherent_handle2); > + return false; >  } >   >  static bool arcmsr_hbaC_get_config(struct AdapterControlBlock *pACB) > > Reviewed-by: Johannes Thumshirn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/