Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753644AbbKYMKn (ORCPT ); Wed, 25 Nov 2015 07:10:43 -0500 Received: from smtp2-g21.free.fr ([212.27.42.2]:10338 "EHLO smtp2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752457AbbKYMKl (ORCPT ); Wed, 25 Nov 2015 07:10:41 -0500 Subject: Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller To: Mans Rullgard , linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier References: <1447958026-3015-1-git-send-email-mans@mansr.com> <1447958026-3015-3-git-send-email-mans@mansr.com> <56558E13.6030703@free.fr> From: Mason Message-ID: <5655A537.3040707@free.fr> Date: Wed, 25 Nov 2015 13:10:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39 MIME-Version: 1.0 In-Reply-To: <56558E13.6030703@free.fr> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 603 Lines: 19 > + status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); > + status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); In my local branch, I wrote: #define IRQ_CTL_LO 0 status_lo = intc_readl(chip, chip->ctl + IRQ_CTL_LO + IRQ_STATUS); status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); (I'm a sucker for symmetry) Regards. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/