Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753833AbbKYMMp (ORCPT ); Wed, 25 Nov 2015 07:12:45 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:41084 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753429AbbKYMMn convert rfc822-to-8bit (ORCPT ); Wed, 25 Nov 2015 07:12:43 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Mason Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Jason Cooper , Marc Zyngier Subject: Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller References: <1447958026-3015-1-git-send-email-mans@mansr.com> <1447958026-3015-3-git-send-email-mans@mansr.com> <56558E13.6030703@free.fr> <5655A537.3040707@free.fr> Date: Wed, 25 Nov 2015 12:12:42 +0000 In-Reply-To: <5655A537.3040707@free.fr> (Mason's message of "Wed, 25 Nov 2015 13:10:31 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 25 Mason writes: >> + status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); >> + status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); > > In my local branch, I wrote: > > #define IRQ_CTL_LO 0 > > status_lo = intc_readl(chip, chip->ctl + IRQ_CTL_LO + IRQ_STATUS); > status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); > > (I'm a sucker for symmetry) Nothing wrong with a little symmetry, though in this case I think the extra macro only confuses matters. -- M?ns Rullg?rd mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/