Date: Wed, 25 Nov 2015 13:20:38 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: Yunlong Song <yunlong.song@huawei.com>, paulus@samba.org, mingo@redhat.com,
        acme@kernel.org, linux-kernel@vger.kernel.org, namhyung@kernel.org,
        ast@kernel.org, masami.hiramatsu.pt@hitachi.com, kan.liang@intel.com,
        adrian.hunter@intel.com, jolsa@kernel.org, dsahern@gmail.com,
        bp@alien8.de, jean.pihet@linaro.org, rric@kernel.org,
        xiakaixu@huawei.com, hekuang@huawei.com
Subject: Re: [PATCH] perf record: Add snapshot mode support for perf's
 regular events
Message-ID: <20151125122038.GA17308@twins.programming.kicks-ass.net>
References: <1448373632-8806-1-git-send-email-yunlong.song@huawei.com>
 <20151125092728.GZ17308@twins.programming.kicks-ass.net>
 <565582E0.7070202@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <565582E0.7070202@huawei.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1216
Lines: 25

On Wed, Nov 25, 2015 at 05:44:00PM +0800, Wangnan (F) wrote:
> 
> 
> On 2015/11/25 17:27, Peter Zijlstra wrote:
> >On Tue, Nov 24, 2015 at 10:00:31PM +0800, Yunlong Song wrote:
> >>In our patch, we create and maintain a user space ring buffer to store
> >>perf's tracing info, instead of directly writing to perf.data file as
> >>before. In snapshot mode, only a SIGUSR2 signal can trigger perf to dump
> >>the tracing info currently stored in the user space ring buffer to
> >>perf.data file.
> >I would very much like to first fix the perf overwrite mode: see
> >lkml.kernel.org/r/20151023151205.GW11639@twins.programming.kicks-ass.net
> 
> I think they can be done in parallel. We can first do something with
> tracking events and perf's output file, and wait for kernel level
> overwrite mode fixed, then decide whether to implement perf's own
> ringbuffer.

That seems backwards; why would you ever want to endlessly copy the
events if you're not going to use them?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/