Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753865AbbKYNCb (ORCPT ); Wed, 25 Nov 2015 08:02:31 -0500 Received: from proxima.lp0.eu ([81.2.80.65]:48445 "EHLO proxima.lp0.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753213AbbKYNCR (ORCPT ); Wed, 25 Nov 2015 08:02:17 -0500 Message-ID: <726719450643bb69683224d731b582b0df27fe1f@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid> In-Reply-To: <56552099.7070709@roeck-us.net> References: <5650BFD6.5030700@simon.arlott.org.uk> <5650C08C.6090300@simon.arlott.org.uk> <5650E2FA.6090408@roeck-us.net> <5650E5BB.6020404@simon.arlott.org.uk> <56512937.6030903@roeck-us.net> <5651CB13.4090704@simon.arlott.org.uk> <5651CBF0.30904@simon.arlott.org.uk> <56552099.7070709@roeck-us.net> Date: Wed, 25 Nov 2015 13:02:10 -0000 Subject: Re: [PATCH 5/10] watchdog: bcm63xx_wdt: Use WATCHDOG_CORE From: "Simon Arlott" To: "Guenter Roeck" Cc: "devicetree@vger.kernel.org" , "Ralf Baechle" , "Thomas Gleixner" , "Jason Cooper" , "Marc Zyngier" , "Kevin Cernekee" , "Florian Fainelli" , "Wim Van Sebroeck" , "Maxime Bizon" , "Linux Kernel Mailing List" , linux-mips@linux-mips.org, linux-watchdog@vger.kernel.org, "Rob Herring" , "Pawel Moll" , "Mark Rutland" , "Ian Campbell" , "Kumar Gala" , "Jonas Gorski" User-Agent: SquirrelMail/1.4.22 MIME-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1164 Lines: 32 On Wed, November 25, 2015 02:44, Guenter Roeck wrote: > The "running" flag should no longer be needed. watchdog_active() > should provide that information. I'm going to need to keep that because I need to know if it's running in the interrupt handler, and wdd->lock is a mutex. >> @@ -306,17 +202,18 @@ unregister_timer: >> >> static int bcm63xx_wdt_remove(struct platform_device *pdev) >> { >> - if (!nowayout) >> - bcm63xx_wdt_hw_stop(); >> + struct watchdog_device *wdd = platform_get_drvdata(pdev); >> >> - misc_deregister(&bcm63xx_wdt_miscdev); >> bcm63xx_timer_unregister(TIMER_WDT_ID); >> + watchdog_unregister_device(wdd); > > Shouldn't that come first, before unregistering the timer ? No, because wdd->dev is used in the interrupt handler. I will have to move registration of the interrupt to after creating the watchdog because it could currently be used before wdd->dev is set. -- Simon Arlott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/