Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753943AbbKYNN1 (ORCPT ); Wed, 25 Nov 2015 08:13:27 -0500 Received: from m50-132.163.com ([123.125.50.132]:35886 "EHLO m50-132.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbbKYNNW (ORCPT ); Wed, 25 Nov 2015 08:13:22 -0500 From: Geliang Tang To: David Airlie , Rob Clark , jilai wang Cc: Geliang Tang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] drm/msm/mdp: fix a problematic usage of WARN_ON() Date: Wed, 25 Nov 2015 21:12:14 +0800 Message-Id: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com> X-Mailer: git-send-email 2.5.0 X-CM-TRANSID: DNGowEDpB0W3s1VWE3i5AQ--.3373S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gw1kKF17KF1rXFW7CrykXwb_yoW3XFg_CF 1xKFZxXrsakF9Yvr1UZrWSvFyI9wn8uFs5Wr98tFyayr4xXr15C34UKr18Wr1rZF48GFZx C3W8Wr4rCFsFqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU1hL07UUUUU== X-Originating-IP: [116.77.146.156] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbioxa9mVUL27aNOAABsW Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 30 WARN_ON() takes a condition rather than a format string. This patch converted WARN_ON() to WARN() instead. Signed-off-by: Geliang Tang --- drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.h b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.h index 8a7f6e1..00f7ecc 100644 --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.h +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.h @@ -157,7 +157,7 @@ static inline uint32_t mixercfg(uint32_t mixer_cfg, int mixer, COND(mixer == 1, MDP4_LAYERMIXER_IN_CFG_PIPE6_MIXER1); break; default: - WARN_ON("invalid pipe"); + WARN(1, "invalid pipe"); break; } -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/