Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753905AbbKYNNN (ORCPT ); Wed, 25 Nov 2015 08:13:13 -0500 Received: from m50-135.163.com ([123.125.50.135]:60537 "EHLO m50-135.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753753AbbKYNNG (ORCPT ); Wed, 25 Nov 2015 08:13:06 -0500 From: Geliang Tang To: David Airlie , Thomas Hellstrom , Sinclair Yeh , Charmaine Lee Cc: Geliang Tang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON() Date: Wed, 25 Nov 2015 21:12:15 +0800 Message-Id: <8bb789c0803579a01e1ee977ed67408c422acd79.1448456395.git.geliangtang@163.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com> References: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com> In-Reply-To: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com> References: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com> X-CM-TRANSID: D9GowABH7468s1VWiDlWAA--.2310S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gw1kKF17KrWrtr15tw4fKrg_yoWfGrg_GF yUJr4DXr4DuF93ZF1ay3yrt34jk3Z7Zrs5Cw1aqa43KFsrJry7Kry5KrykXr1xWFW7Gr98 Xa1DWr1fAr1xujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjsqXPUUUUU== X-Originating-IP: [116.77.146.156] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/xtbByhW9mVO+gH7ERwAAsr Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1068 Lines: 30 WARN_ON() takes a condition rather than a format string. This patch converted WARN_ON() to WARN() instead. Signed-off-by: Geliang Tang --- drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c index a8baf5f..b6a0806 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c @@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes, else if (ctx_id == SVGA3D_INVALID_ID) ret = vmw_local_fifo_reserve(dev_priv, bytes); else { - WARN_ON("Command buffer has not been allocated.\n"); + WARN(1, "Command buffer has not been allocated.\n"); ret = NULL; } if (IS_ERR_OR_NULL(ret)) { -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/