Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958AbbKYNOg (ORCPT ); Wed, 25 Nov 2015 08:14:36 -0500 Received: from m50-134.163.com ([123.125.50.134]:44803 "EHLO m50-134.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752048AbbKYNOc (ORCPT ); Wed, 25 Nov 2015 08:14:32 -0500 From: Geliang Tang To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Scott Wood , David Gibson Cc: Geliang Tang , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/7] powerpc: fix a problematic usage of WARN() Date: Wed, 25 Nov 2015 21:12:20 +0800 Message-Id: <84a366614b84091cd4bd354e8b65dd51c1762a52.1448456395.git.geliangtang@163.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com> References: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com> In-Reply-To: <06d69890c56bd84a831a1dccee26e34b4988a241.1448456395.git.geliangtang@163.com> References: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com> <8bb789c0803579a01e1ee977ed67408c422acd79.1448456395.git.geliangtang@163.com> <582529c23f77af64373f59fa92e29186df700d79.1448456395.git.geliangtang@163.com> <7701ed112cc71a9a17ba5b3022166011a98d0dca.1448456395.git.geliangtang@163.com> <06d69890c56bd84a831a1dccee26e34b4988a241.1448456395.git.geliangtang@163.com> X-CM-TRANSID: DtGowEB5YUzIs1VWBjomAw--.1318S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF48tFW5GFWkKw1xJr1UKFg_yoW3CFg_Kw s7Zw48K34vvF1UAa98Ca1fGrn7Kw4UtFn5Kr1Y9wsFyFnxXwn8Ca9xtF17Jr1kJr18JrZ0 ka4xGFyDu3WI9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUbRuWJUUUUU== X-Originating-IP: [116.77.146.156] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbivwm9mVWBOkM-swAAsz Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1026 Lines: 30 WARN() takes a condition and a format string. The condition was omitted. So I added it. Signed-off-by: Geliang Tang --- arch/powerpc/kernel/setup_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c index 5c03a6a..726a9fb 100644 --- a/arch/powerpc/kernel/setup_64.c +++ b/arch/powerpc/kernel/setup_64.c @@ -127,7 +127,7 @@ static void setup_tlb_core_data(void) !mmu_has_feature(MMU_FTR_USE_TLBRSRV) && book3e_htw_mode != PPC_HTW_E6500) { /* Should we panic instead? */ - WARN_ONCE("%s: unsupported MMU configuration -- expect problems\n", + WARN_ONCE(1, "%s: unsupported MMU configuration -- expect problems\n", __func__); } } -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/