Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752328AbbKYNfa (ORCPT ); Wed, 25 Nov 2015 08:35:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54258 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751784AbbKYNf3 (ORCPT ); Wed, 25 Nov 2015 08:35:29 -0500 Message-ID: <1448458528.32118.25.camel@redhat.com> Subject: Re: [PATCH 5/7] vfio: fix a problematic usage of WARN() From: Alex Williamson To: Geliang Tang Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 25 Nov 2015 06:35:28 -0700 In-Reply-To: References: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1187 Lines: 36 On Wed, 2015-11-25 at 21:12 +0800, Geliang Tang wrote: > WARN() takes a condition and a format string. The condition was > omitted. So I added it. > > Signed-off-by: Geliang Tang > --- > drivers/vfio/vfio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c > index de632da..9da0703 100644 > --- a/drivers/vfio/vfio.c > +++ b/drivers/vfio/vfio.c > @@ -682,7 +682,7 @@ static int vfio_group_nb_add_dev(struct vfio_group *group, struct device *dev) > return 0; > > /* TODO Prevent device auto probing */ > - WARN("Device %s added to live group %d!\n", dev_name(dev), > + WARN(1, "Device %s added to live group %d!\n", dev_name(dev), > iommu_group_id(group->iommu_group)); > > return 0; This was already reported and I've got a patch queued to resolve it: https://www.mail-archive.com/kvm@vger.kernel.org/msg123061.html Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/