Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754046AbbKYNnh (ORCPT ); Wed, 25 Nov 2015 08:43:37 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:33981 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbbKYNnf (ORCPT ); Wed, 25 Nov 2015 08:43:35 -0500 From: LABBE Corentin To: minyard@acm.org, openipmi-developer@lists.sourceforge.net Cc: LABBE Corentin , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] ipmi: constify the reason parameter of start_error_recovery Date: Wed, 25 Nov 2015 14:43:23 +0100 Message-Id: <1448459006-6118-2-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.4.10 In-Reply-To: <1448459006-6118-1-git-send-email-clabbe.montjoie@gmail.com> References: <1448459006-6118-1-git-send-email-clabbe.montjoie@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1714 Lines: 44 Both start_error_recovery() function are different but they didn't modify the reason parameter. Furthermore, the reason parameter is always given string literal. Signed-off-by: LABBE Corentin --- drivers/char/ipmi/ipmi_kcs_sm.c | 2 +- drivers/char/ipmi/ipmi_smic_sm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_kcs_sm.c b/drivers/char/ipmi/ipmi_kcs_sm.c index 1da61af..9ec38e6 100644 --- a/drivers/char/ipmi/ipmi_kcs_sm.c +++ b/drivers/char/ipmi/ipmi_kcs_sm.c @@ -202,7 +202,7 @@ static inline void write_next_byte(struct si_sm_data *kcs) (kcs->write_count)--; } -static inline void start_error_recovery(struct si_sm_data *kcs, char *reason) +static inline void start_error_recovery(struct si_sm_data *kcs, const char *reason) { (kcs->error_retries)++; if (kcs->error_retries > MAX_ERROR_RETRIES) { diff --git a/drivers/char/ipmi/ipmi_smic_sm.c b/drivers/char/ipmi/ipmi_smic_sm.c index 8f7c73f..21ad645 100644 --- a/drivers/char/ipmi/ipmi_smic_sm.c +++ b/drivers/char/ipmi/ipmi_smic_sm.c @@ -227,7 +227,7 @@ static inline void write_si_sm_data(struct si_sm_data *smic, smic->io->outputb(smic->io, 0, data); } -static inline void start_error_recovery(struct si_sm_data *smic, char *reason) +static inline void start_error_recovery(struct si_sm_data *smic, const char *reason) { (smic->error_retries)++; if (smic->error_retries > SMIC_MAX_ERROR_RETRIES) { -- 2.4.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/