Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754128AbbKYNrt (ORCPT ); Wed, 25 Nov 2015 08:47:49 -0500 Received: from mga03.intel.com ([134.134.136.65]:42441 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbbKYNrr convert rfc822-to-8bit (ORCPT ); Wed, 25 Nov 2015 08:47:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,342,1444719600"; d="scan'208";a="2119920" From: "Grumbach, Emmanuel" To: Geliang Tang , "Berg, Johannes" , linuxwifi , Kalle Valo CC: "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Thread-Topic: [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Thread-Index: AQHRJ4MKp5EcHG/VREyfcj+I6/PGM56swKLw Date: Wed, 25 Nov 2015 13:47:42 +0000 Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB32E8FC5E8@hasmsx107.ger.corp.intel.com> References: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com> <8bb789c0803579a01e1ee977ed67408c422acd79.1448456395.git.geliangtang@163.com> <582529c23f77af64373f59fa92e29186df700d79.1448456395.git.geliangtang@163.com> <7701ed112cc71a9a17ba5b3022166011a98d0dca.1448456395.git.geliangtang@163.com> In-Reply-To: <7701ed112cc71a9a17ba5b3022166011a98d0dca.1448456395.git.geliangtang@163.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.184.70.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 37 > > WARN_ON_ONCE() takes a condition rather than a format string. This patch > converted WARN_ON_ONCE() to WARN_ONCE() instead. > > Signed-off-by: Geliang Tang > --- > drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Already fixed. Thanks. > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c > b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c > index d1ad103..58d7bee 100644 > --- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c > @@ -1827,7 +1827,7 @@ static int rs_switch_to_column(struct iwl_mvm > *mvm, > rate->type = lq_sta->is_vht ? LQ_VHT_MIMO2 : > LQ_HT_MIMO2; > rate_mask = lq_sta->active_mimo2_rate; > } else { > - WARN_ON_ONCE("Bad column mode"); > + WARN_ONCE(1, "Bad column mode"); > } > > if (column->mode != RS_LEGACY) { > -- > 2.5.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/