Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753752AbbKYNzQ (ORCPT ); Wed, 25 Nov 2015 08:55:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44410 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752863AbbKYNzO (ORCPT ); Wed, 25 Nov 2015 08:55:14 -0500 Subject: Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource To: Ching Huang , hch@infradead.org, jbottomley@parallels.com, dan.carpenter@oracle.com, agordeev@redhat.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hare@suse.de, jthumshirn@suse.de References: <1448451683.4670.35.camel@Centos6.3-64> Cc: hch@lst.de From: Tomas Henzl Message-ID: <5655BDBD.404@redhat.com> Date: Wed, 25 Nov 2015 14:55:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448451683.4670.35.camel@Centos6.3-64> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1960 Lines: 54 On 25.11.2015 12:41, Ching Huang wrote: > From: Ching Huang > > Releasing allocated resource if get configuration data failed. > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c > --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-24 11:35:26.000000000 +0800 > +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-25 19:04:44.590970000 +0800 > @@ -2664,7 +2664,7 @@ static bool arcmsr_hbaB_get_config(struc > if (!arcmsr_hbaB_wait_msgint_ready(acb)) { > printk(KERN_NOTICE "arcmsr%d: wait 'get adapter firmware \ > miscellaneous data' timeout \n", acb->host->host_no); > - return false; > + goto err_free_dma; > } > count = 8; > while (count){ > @@ -2707,6 +2707,10 @@ static bool arcmsr_hbaB_get_config(struc > acb->firm_cfg_version = readl(®->message_rwbuffer[25]); /*firm_cfg_version,25,100-103*/ > /*firm_ide_channels,4,16-19*/ > return true; > +err_free_dma: > + dma_free_coherent(&acb->pdev->dev, acb->roundup_ccbsize, > + acb->dma_coherent2, acb->dma_coherent_handle2); > + return false; > } > The resource should be released here, that is okay. How works the resource management when the eh_bus_reset_handler is called ? It looks to me that you allocate a new acb->dma_coherent2 without releasing it before. Btw. is it needed in that handler to re-read the firmware-spec? Tomas > static bool arcmsr_hbaC_get_config(struct AdapterControlBlock *pACB) > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/