Subject: Re: [alsa-devel] [PATCH 2/2] ALSA: compress: Pass id string to
 snd_compress_new
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>, vinod.koul@intel.com,
        tiwai@suse.com, broonie@kernel.org
References: <1448444918-29760-1-git-send-email-rf@opensource.wolfsonmicro.com>
 <1448444918-29760-3-git-send-email-rf@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Message-ID: <5655CAE8.80705@linux.intel.com>
Date: Wed, 25 Nov 2015 08:51:20 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1448444918-29760-3-git-send-email-rf@opensource.wolfsonmicro.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 905
Lines: 22


> @@ -689,7 +689,13 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num)
>   		compr->ops->copy = soc_compr_copy;
>
>   	mutex_init(&compr->lock);
> -	ret = snd_compress_new(rtd->card->snd_card, num, direction, compr);
> +
> +	snprintf(new_name, sizeof(new_name), "%s %s-%d",
> +		 rtd->dai_link->stream_name,
> +		 rtd->codec_dai->name, num);

Adding an ID with a human-readable name sounds good.
Wondering though if the codec_dai name is relevant for compressed 
streams? In all the configurations we have with DPCM the name is 
snd-soc-dummy-dai, there is no connection to the codec proper. 
stream_name and id should be good enough, no?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/