Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753224AbbKYPPs (ORCPT ); Wed, 25 Nov 2015 10:15:48 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:41980 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751944AbbKYPPr (ORCPT ); Wed, 25 Nov 2015 10:15:47 -0500 Subject: Re: [alsa-devel] [PATCH 2/2] ALSA: compress: Pass id string to snd_compress_new From: Richard Fitzgerald To: Pierre-Louis Bossart CC: , , , , , , In-Reply-To: <5655CAE8.80705@linux.intel.com> References: <1448444918-29760-1-git-send-email-rf@opensource.wolfsonmicro.com> <1448444918-29760-3-git-send-email-rf@opensource.wolfsonmicro.com> <5655CAE8.80705@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 25 Nov 2015 15:15:34 +0000 Message-ID: <1448464534.3536.64.camel@rf-debian.wolfsonmicro.main> MIME-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1511250266 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1557 Lines: 36 On Wed, 2015-11-25 at 08:51 -0600, Pierre-Louis Bossart wrote: > > @@ -689,7 +689,13 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num) > > compr->ops->copy = soc_compr_copy; > > > > mutex_init(&compr->lock); > > - ret = snd_compress_new(rtd->card->snd_card, num, direction, compr); > > + > > + snprintf(new_name, sizeof(new_name), "%s %s-%d", > > + rtd->dai_link->stream_name, > > + rtd->codec_dai->name, num); > > Adding an ID with a human-readable name sounds good. > Wondering though if the codec_dai name is relevant for compressed > streams? I think it is, that was the original reason I wrote this patch. I'm writing some automated tests where I have to know what each stream is really connected to and the DAI name is important for that (in my case anyway). Since the PCM core already provides that in the info file it seemed reasonable to do the same for compressed. > > In all the configurations we have with DPCM the name is > snd-soc-dummy-dai, there is no connection to the codec proper. > stream_name and id should be good enough, no? There's going to be systems where the DAI name is something real and I can't see a disadvantage in providing that extra piece of information, just in case it's useful. I've kept the format the same as the equivalent for PCM -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/