Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbbKYPtI (ORCPT ); Wed, 25 Nov 2015 10:49:08 -0500 Received: from smtp-outbound-1.vmware.com ([208.91.2.12]:33319 "EHLO smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbbKYPtG (ORCPT ); Wed, 25 Nov 2015 10:49:06 -0500 From: "Sinclair Yeh" Date: Wed, 25 Nov 2015 07:50:22 -0800 To: Geliang Tang Cc: David Airlie , Thomas Hellstrom , Charmaine Lee , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON() Message-ID: <20151125155022.GA11051@syeh-linux> References: <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com> <8bb789c0803579a01e1ee977ed67408c422acd79.1448456395.git.geliangtang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bb789c0803579a01e1ee977ed67408c422acd79.1448456395.git.geliangtang@163.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 33 Reviewed-by: Sinclair Yeh On Wed, Nov 25, 2015 at 09:12:15PM +0800, Geliang Tang wrote: > WARN_ON() takes a condition rather than a format string. This patch > converted WARN_ON() to WARN() instead. > > Signed-off-by: Geliang Tang > --- > drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c > index a8baf5f..b6a0806 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c > @@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes, > else if (ctx_id == SVGA3D_INVALID_ID) > ret = vmw_local_fifo_reserve(dev_priv, bytes); > else { > - WARN_ON("Command buffer has not been allocated.\n"); > + WARN(1, "Command buffer has not been allocated.\n"); > ret = NULL; > } > if (IS_ERR_OR_NULL(ret)) { > -- > 2.5.0 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/