Subject: Re: [PATCH 09/10] KVM: x86: MMU: Move parent_pte handling from
 kvm_mmu_get_page() to link_shadow_page()
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
        Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
References: <20151120174005.9880b89f54eee2cec2422da5@lab.ntt.co.jp>
 <20151120174805.a91793d1fce2f0a493f1b955@lab.ntt.co.jp>
 <564EE08B.4040100@linux.intel.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5655E2B5.4030709@redhat.com>
Date: Wed, 25 Nov 2015 17:32:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <564EE08B.4040100@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 814
Lines: 25


On 20/11/2015 09:57, Xiao Guangrong wrote:
> 
> 
> You can move this patch to the front of
> [PATCH 08/10] KVM: x86: MMU: Use for_each_rmap_spte macro instead of
> pte_list_walk()
> 
> By moving kvm_mmu_mark_parents_unsync() to the behind of mmu_spte_set()
> (then the parent
> spte is present now), you can directly clean up for_each_rmap_spte().

So basically squash together the two patches (8/10 and 9/10) except the
change to kvm_mmu_mark_parents_unsync; then in the second patch switch
from pte_list_walk to for_each_rmap_spte.

That makes sense indeed.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/