Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754203AbbKYQeO (ORCPT ); Wed, 25 Nov 2015 11:34:14 -0500 Received: from foss.arm.com ([217.140.101.70]:40978 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753139AbbKYQeK (ORCPT ); Wed, 25 Nov 2015 11:34:10 -0500 Date: Wed, 25 Nov 2015 16:34:02 +0000 From: Mark Rutland To: Eric Dumazet Cc: netdev@vger.kernel.org, isubramanian@apm.com, kchudgar@apm.com, linux-kernel@vger.kernel.org, ryabinin.a.a@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: KASAN failures in X-Gene ethernet driver in v4.4-rc2 Message-ID: <20151125163402.GA29094@leverpostej> References: <20151125155753.GE12434@leverpostej> <1448468256.24696.5.camel@edumazet-glaptop2.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448468256.24696.5.camel@edumazet-glaptop2.roam.corp.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 37 On Wed, Nov 25, 2015 at 08:17:36AM -0800, Eric Dumazet wrote: > On Wed, 2015-11-25 at 15:59 +0000, Mark Rutland wrote: > > xgene_enet_start_xmit > > Please try following trivial fix With that applied KASAN is silent, despite my efforts to trigger the issue, so it looks like that fixes it. Thanks, Mark. > diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > index 1adfe7036843..9147a0107c44 100644 > --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > @@ -450,12 +450,12 @@ static netdev_tx_t xgene_enet_start_xmit(struct sk_buff *skb, > return NETDEV_TX_OK; > } > > - pdata->ring_ops->wr_cmd(tx_ring, count); > skb_tx_timestamp(skb); > > pdata->stats.tx_packets++; > pdata->stats.tx_bytes += skb->len; > > + pdata->ring_ops->wr_cmd(tx_ring, count); > return NETDEV_TX_OK; > } > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/