Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbbKYQpa (ORCPT ); Wed, 25 Nov 2015 11:45:30 -0500 Received: from mail-ob0-f174.google.com ([209.85.214.174]:36477 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbbKYQp2 (ORCPT ); Wed, 25 Nov 2015 11:45:28 -0500 Subject: Re: [PATCH] block: kmemleak: Track the page allocations for struct request To: William Dauchy References: <1442250962-9906-1-git-send-email-catalin.marinas@arm.com> <55F70236.1030306@kernel.dk> Cc: Catalin Marinas , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Bart Van Assche From: Jens Axboe Message-ID: <5655E5A6.9060502@kernel.dk> Date: Wed, 25 Nov 2015 09:45:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1726 Lines: 48 On 11/25/2015 04:04 AM, William Dauchy wrote: > Hi Jens, > > On Mon, Sep 14, 2015 at 7:21 PM, Jens Axboe wrote: >> On 09/14/2015 11:16 AM, Catalin Marinas wrote: >>> >>> The pages allocated for struct request contain pointers to other slab >>> allocations (via ops->init_request). Since kmemleak does not track/scan >>> page allocations, the slab objects will be reported as leaks (false >>> positives). This patch adds kmemleak callbacks to allow tracking of such >>> pages. >>> >>> Signed-off-by: Catalin Marinas >>> Reported-by: Bart Van Assche >>> Tested-by: Bart Van Assche >>> Cc: Christoph Hellwig >>> Cc: Jens Axboe >>> --- >>> >>> Jens, >>> >>> I just realised that no-one has picked this patch up for -rc1. It was >>> discussed here previously: >>> >>> >>> http://lkml.kernel.org/r/20150803104309.GB4033@e104818-lin.cambridge.arm.com >>> >>> Since it touches the block layer, are you fine with merging it? >> >> >> Yeah looks simple enough for me, not sure why it got missed. I'll add it for >> 4.4-rc1, thanks. > > I saw the related kmemleaks reports on my v4.1.x kernel. Since it's > actually fixing these wrong reports, do you think it could be a good > candidate for -stable tree? I'd say it's borderline. It's fixing a tracking bug. Unless others feel strongly otherwise, I don't think it's stable material. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/