Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752802AbbKYQql (ORCPT ); Wed, 25 Nov 2015 11:46:41 -0500 Received: from mail.kernel.org ([198.145.29.136]:53711 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752208AbbKYQqk (ORCPT ); Wed, 25 Nov 2015 11:46:40 -0500 Date: Wed, 25 Nov 2015 10:46:36 -0600 From: Bjorn Helgaas To: Vineet Gupta Cc: Joao Pinto , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , Carlos Palminha , Alexey Brodkin , arcml , Arnd Bergmann Subject: Re: [PATCH 2/2] PCI support added to ARC Message-ID: <20151125164636.GB1380@localhost> References: <9b80d6c1db4d7e2b5ee5dc0056a3d8284e7c2b9b.1448375184.git.jpinto@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 15 On Wed, Nov 25, 2015 at 05:25:37AM +0000, Vineet Gupta wrote: > On Tuesday 24 November 2015 08:02 PM, Joao Pinto wrote: > > + pr_err("PCI: Device %s not available because"/ > > + " of resource collisions\n", pci_name(dev)); > > Better not to break strings - even if they sometime exceed line sz limit of 80. > You could anyways reduce the string content herer. Also use dev_err() instead of pr_err(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/