Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752696AbbKYQyM (ORCPT ); Wed, 25 Nov 2015 11:54:12 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:31042 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbbKYQyK (ORCPT ); Wed, 25 Nov 2015 11:54:10 -0500 Date: Wed, 25 Nov 2015 11:53:55 -0500 From: Konrad Rzeszutek Wilk To: Peng Fan Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Boris Ostrovsky , David Vrabel , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [RFC 1/1] xen: block: correct setting for xen_blkif_max_ring_order Message-ID: <20151125165345.GA19188@x230.dumpdata.com> References: <1448447161-15464-1-git-send-email-van.freenix@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1448447161-15464-1-git-send-email-van.freenix@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1767 Lines: 52 On Wed, Nov 25, 2015 at 06:26:01PM +0800, Peng Fan wrote: > According to this piece code: > " > pr_info("Invalid max_ring_order (%d), will use default max: %d.\n", > xen_blkif_max_ring_order, XENBUS_MAX_RING_GRANT_ORDER); > " > if xen_blkif_max_ring_order is bigger that XENBUS_MAX_RING_GRANT_ORDER, > need to set xen_blkif_max_ring_order using XENBUS_MAX_RING_GRANT_ORDER, > but not 0. > > Signed-off-by: Peng Fan > Cc: Konrad Rzeszutek Wilk > Cc: Boris Ostrovsky > Cc: David Vrabel > Cc: "Roger Pau Monn?" > --- > > Hi, > > I am new to xen and reading related soure code, not sure whether > this is correct. Please comments. Applied to 'devel/for-jens-4.5'. Thanks! > > Thanks > > drivers/block/xen-blkfront.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c > index 0823a96..883b9fa 100644 > --- a/drivers/block/xen-blkfront.c > +++ b/drivers/block/xen-blkfront.c > @@ -2126,7 +2126,7 @@ static int __init xlblk_init(void) > if (xen_blkif_max_ring_order > XENBUS_MAX_RING_PAGE_ORDER) { > pr_info("Invalid max_ring_order (%d), will use default max: %d.\n", > xen_blkif_max_ring_order, XENBUS_MAX_RING_PAGE_ORDER); > - xen_blkif_max_ring_order = 0; > + xen_blkif_max_ring_order = XENBUS_MAX_RING_PAGE_ORDER; > } > > if (!xen_has_pv_disk_devices()) > -- > 2.6.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/