Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752488AbbKYSZJ (ORCPT ); Wed, 25 Nov 2015 13:25:09 -0500 Received: from down.free-electrons.com ([37.187.137.238]:53341 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751277AbbKYSZE (ORCPT ); Wed, 25 Nov 2015 13:25:04 -0500 From: Gregory CLEMENT To: Marcin Wojtas Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, davem@davemloft.net, linux@arm.linux.org.uk, sebastian.hesselbarth@gmail.com, andrew@lunn.ch, jason@lakedaemon.net, thomas.petazzoni@free-electrons.com, simon.guinot@sequanux.org, nadavh@marvell.com, alior@marvell.com, xswang@marvell.com, myair@marvell.com, nitroshift@yahoo.com, jaz@semihalf.com, tn@semihalf.com, Subject: Re: [PATCH 03/13] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG References: <1448178839-3541-1-git-send-email-mw@semihalf.com> <1448178839-3541-4-git-send-email-mw@semihalf.com> Date: Wed, 25 Nov 2015 19:25:02 +0100 In-Reply-To: <1448178839-3541-4-git-send-email-mw@semihalf.com> (Marcin Wojtas's message of "Sun, 22 Nov 2015 08:53:49 +0100") Message-ID: <87oaei7x8h.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1619 Lines: 51 Hi Marcin, On dim., nov. 22 2015, Marcin Wojtas wrote: > MVNETA_RXQ_HW_BUF_ALLOC bit which controls enabling hardware buffer > allocation was mistakenly set as BIT(1). This commit fixes the > assignment. I confirm it from the datasheet I got: Reviewed-by: Gregory CLEMENT Thanks, Gregory > > Signed-off-by: Marcin Wojtas > Cc: # v3.8+ > --- > drivers/net/ethernet/marvell/mvneta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index 0f30aaa..d12b8c6 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -36,7 +36,7 @@ > > /* Registers */ > #define MVNETA_RXQ_CONFIG_REG(q) (0x1400 + ((q) << 2)) > -#define MVNETA_RXQ_HW_BUF_ALLOC BIT(1) > +#define MVNETA_RXQ_HW_BUF_ALLOC BIT(0) > #define MVNETA_RXQ_PKT_OFFSET_ALL_MASK (0xf << 8) > #define MVNETA_RXQ_PKT_OFFSET_MASK(offs) ((offs) << 8) > #define MVNETA_RXQ_THRESHOLD_REG(q) (0x14c0 + ((q) << 2)) > -- > 1.8.3.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/