Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751795AbbKYS0T (ORCPT ); Wed, 25 Nov 2015 13:26:19 -0500 Received: from resqmta-ch2-08v.sys.comcast.net ([69.252.207.40]:41046 "EHLO resqmta-ch2-08v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751489AbbKYS0M (ORCPT ); Wed, 25 Nov 2015 13:26:12 -0500 Date: Wed, 25 Nov 2015 12:26:10 -0600 (CST) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Michal Hocko cc: Joonsoo Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/vmstat: retrieve more accurate vmstat value In-Reply-To: <20151125180350.GT27283@dhcp22.suse.cz> Message-ID: References: <1448346123-2699-1-git-send-email-iamjoonsoo.kim@lge.com> <20151125025735.GC9563@js1304-P5Q-DELUXE> <20151125180350.GT27283@dhcp22.suse.cz> Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 20 On Wed, 25 Nov 2015, Michal Hocko wrote: > > Simply remove the counter from the vmstat handling and do it differently > > then. > > We definitely do not want yet another set of counters. vmstat counters > are not only to be exported into the userspace. We have in kernel users > as well. I do agree that there are users who can cope with some level of > imprecision though and those which depend on the accuracy can use > zone_page_state_snapshot which doesn't impose any overhead on others. > [...] Ok then the proper patch would be to use zone_page_state() instead of zone_page_state() here instead of modifying zone_page_state(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/