Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462AbbKYSmG (ORCPT ); Wed, 25 Nov 2015 13:42:06 -0500 Received: from down.free-electrons.com ([37.187.137.238]:53744 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751939AbbKYSlv (ORCPT ); Wed, 25 Nov 2015 13:41:51 -0500 Date: Wed, 25 Nov 2015 19:41:49 +0100 From: Alexandre Belloni To: Saurabh Sengar Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/rtc/rtc-tps65910.c: Add IRQF_ONESHOT to interrupt flags Message-ID: <20151125184149.GQ3950@piout.net> References: <1448475597-11228-1-git-send-email-saurabh.truth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448475597-11228-1-git-send-email-saurabh.truth@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 25 Hi, On 25/11/2015 at 23:49:57 +0530, Saurabh Sengar wrote : > If no primary handler is specified for threaded_irq then a > default one is assigned which always returns IRQ_WAKE_THREAD. > This handler requires the IRQF_ONESHOT, because the source of > interrupt is not disabled > Are you sure this is necessary? The parent irqchip is the mfd and it sets IRQF_ONESHOT. Does that solve a real problem or is it a false positive coming from a static analysis tool? -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/