Date: Wed, 25 Nov 2015 15:40:57 -0500
From: Tejun Heo <tj@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Aleksa Sarai <cyphar@cyphar.com>, Johannes Weiner <hannes@cmpxchg.org>,
        Li Zefan <lizefan@huawei.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH?] race between cgroup_subsys->fork() and cgroup_migrate()
Message-ID: <20151125204057.GF14240@htj.duckdns.org>
References: <20151125163427.GA8139@redhat.com>
 <20151125195138.GC14240@htj.duckdns.org>
 <20151125195410.GD14240@htj.duckdns.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151125195410.GD14240@htj.duckdns.org>
User-Agent: Mutt/1.5.23 (2015-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 988
Lines: 24

On Wed, Nov 25, 2015 at 02:54:10PM -0500, Tejun Heo wrote:
> On Wed, Nov 25, 2015 at 02:51:38PM -0500, Tejun Heo wrote:
> > Sounds perfect.  As this needs to go through -stable, can you please
> > resend the patch with proper description and SOB?  Please also update
> > the now incorrect comment in can_attach.
> 
> Ooh, the patch triggers RCU warning from task_css().  It's spurious
> and I think the right thing to do at least for now is using
> task_css_check() and explain what's going on.

And I spotted a bug in cgroup core in controller enable path.  While
the race between fork and attach exists and needs to be fixed, I think
the cgroup core bug is the main source of discrepancy.  Will update
once I learn more.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/