Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752685AbbKYWM7 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Nov 2015 17:12:59 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:33550 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752257AbbKYWMw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Nov 2015 17:12:52 -0500
Date: Wed, 25 Nov 2015 17:12:34 -0500
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Bob Liu <bob.liu@oracle.com>
Cc: xen-devel@lists.xen.org, linux-kernel@vger.kernel.org,
        roger.pau@citrix.com, felipe.franciosi@citrix.com, axboe@fb.com,
        avanzini.arianna@gmail.com, rafal.mielniczuk@citrix.com,
        jonathan.davies@citrix.com, david.vrabel@citrix.com
Subject: Re: [PATCH v5 00/10] xen-block: multi hardware-queues/rings support
Message-ID: <20151125221234.GA22905@x230.dumpdata.com>
References: <1447470739-18136-1-git-send-email-bob.liu@oracle.com>
 <20151125192507.GD19188@x230.dumpdata.com>
 <20151125205603.GB20267@x230.dumpdata.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151125205603.GB20267@x230.dumpdata.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2341
Lines: 70

On Wed, Nov 25, 2015 at 03:56:03PM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 25, 2015 at 02:25:07PM -0500, Konrad Rzeszutek Wilk wrote:
> > >   xen/blkback: separate ring information out of struct xen_blkif
> > >   xen/blkback: pseudo support for multi hardware queues/rings
> > >   xen/blkback: get the number of hardware queues/rings from blkfront
> > >   xen/blkback: make pool of persistent grants and free pages per-queue
> > 
> > OK, got to those as well. I have put them in 'devel/for-jens-4.5' and
> > are going to test them overnight before pushing them out.
> > 
> > I see two bugs in the code that we MUST deal with:
> > 
> >  - print_stats () is going to show zero values.
> >  - the sysfs code (VBD_SHOW) aren't converted over to fetch data
> >    from all the rings.
> 
> - kthread_run can't handle the two "name, i" arguments. I see:
> 
> root      5101     2  0 20:47 ?        00:00:00 [blkback.3.xvda-]
> root      5102     2  0 20:47 ?        00:00:00 [blkback.3.xvda-]

And doing save/restore:

xl save <id> /tmp/A;
xl restore /tmp/A;

ends up us loosing the proper state and not getting the ring setup back.
I see this is backend:

[ 2719.448600] vbd vbd-22-51712: -1 guest requested 0 queues, exceeding the maximum of 3.

And XenStore agrees:
tool = ""
 xenstored = ""
local = ""
 domain = ""
  0 = ""
   domid = "0"
   name = "Domain-0"
   device-model = ""
    0 = ""
     state = "running"
   error = ""
    backend = ""
     vbd = ""
      2 = ""
       51712 = ""
        error = "-1 guest requested 0 queues, exceeding the maximum of 3."

.. which also leads to a memory leak as xen_blkbk_remove never gets
called.
> 
> 
> > 
> > > 
> > >  drivers/block/xen-blkback/blkback.c | 386 ++++++++++---------
> > >  drivers/block/xen-blkback/common.h  |  78 ++--
> > >  drivers/block/xen-blkback/xenbus.c  | 359 ++++++++++++------
> > >  drivers/block/xen-blkfront.c        | 718 ++++++++++++++++++++++--------------
> > >  include/xen/interface/io/blkif.h    |  48 +++
> > >  5 files changed, 971 insertions(+), 618 deletions(-)
> > > 
> > > -- 
> > > 1.8.3.1
> > > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/