Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853AbbKYWrT (ORCPT ); Wed, 25 Nov 2015 17:47:19 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:46094 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbbKYWrQ (ORCPT ); Wed, 25 Nov 2015 17:47:16 -0500 Date: Wed, 25 Nov 2015 23:47:08 +0100 From: Francois Romieu To: Jarod Wilson Cc: David Miller , ldap.tester@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: severe regression in alx ethernet driver Message-ID: <20151125224708.GA1640@electric-eye.fr.zoreil.com> References: <20151123.111530.2081520486357118720.davem@davemloft.net> <20151123.111610.2054291192576855643.davem@davemloft.net> <20151124160739.GG38006@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151124160739.GG38006@redhat.com> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 19 Jarod Wilson : [...] > They do at least have a signed-off-by in the patches attached to the bug, > so I'm working on touching up the descriptions and formatting, regression > testing them on my laptop that has an alx-driven E2200 in it (which isn't > affected by this bug), and then I can ship them up for proper review. You can forget the last refill-me-harder patch and save a roundtrip. The driver should 1) prohibit holes in its receive ring, 2) allocate before pushing data up in the stack and 3) drop packets when it can't allocate a fresh buffer. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/