Message-ID: <1448498073.27159.39.camel@decadent.org.uk>
Subject: Re: [PATCH 3.2 22/52] ALSA: hda - Disable 64bit address for
 Creative HDA controllers
From: Ben Hutchings <ben@decadent.org.uk>
To: Luis Henriques <luis.henriques@canonical.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        akpm@linux-foundation.org, Takashi Iwai <tiwai@suse.de>
Date: Thu, 26 Nov 2015 00:34:33 +0000
In-Reply-To: <20151125230509.GB21715@charon>
References: <lsq.1448404438.351251660@decadent.org.uk>
	 <lsq.1448404439.773756352@decadent.org.uk> <20151125230509.GB21715@charon>
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="=-SCNrsI75jr4h3XEFgGFU"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2984
Lines: 78


--=-SCNrsI75jr4h3XEFgGFU
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2015-11-25 at 23:05 +0000, Luis Henriques wrote:
> On Tue, Nov 24, 2015 at 10:33:59PM +0000, Ben Hutchings wrote:
> > 3.2.74-rc1 review patch.=C2=A0=C2=A0If anyone has any objections, pleas=
e let me know.
> >=20
> > ------------------
> >=20
> > From: Takashi Iwai <tiwai@suse.de>
> >=20
> > commit cadd16ea33a938d49aee99edd4758cc76048b399 upstream.
> >=20
> > We've had many reports that some Creative sound cards with CA0132
> > don't work well.=C2=A0=C2=A0Some reported that it starts working after =
reloading
> > the module, while some reported it starts working when a 32bit kernel
> > is used.=C2=A0=C2=A0All these facts seem implying that the chip fails t=
o
> > communicate when the buffer is located in 64bit address.
> >=20
> > This patch addresses these issues by just adding AZX_DCAPS_NO_64BIT
> > flag to the corresponding PCI entries.=C2=A0=C2=A0I casually had a chan=
ce to
> > test an SB Recon3D board, and indeed this seems helping.
> >=20
> > Although this hasn't been tested on all Creative devices, it's safer
> > to assume that this restriction applies to the rest of them, too.=C2=A0=
=C2=A0So
> > the flag is applied to all Creative entries.
> >=20
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > [bwh: Backported to 3.2: drop the change to AZX_DCAPS_PRESET_CTHDA]
>=20
> Is there a reason for dropping this change?=C2=A0=C2=A0Adding the
> AZX_DCAPS_NO_64BIT flag to the AZX_DCAPS_PRESET_CTHDA definition does
> seem to make sense.
[...]

The AZX_DCAPS_PRESET_CTHDA macro was introduced in 3.5.

Ben.

--=20
Ben Hutchings
Unix is many things to many people,
but it's never been everything to anybody.
--=-SCNrsI75jr4h3XEFgGFU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUAVlZTmee/yOyVhhEJAQpnXA//QFziKflrjdnPYqFO/ZoQyEAm6o5Uihv3
R6u+71D+LbHqsGQo6o6atnNc2TDtUGVIVJR+blS6f9lH8j3dgAdUAxT4k8rsz3NM
204qNXqQ4R0QnONWRSzaP3zmgr0iA6MqkTFFRqqz0cnMAVm/Tfs32uHTU1AY/1ai
mDx2fm7VDt7C5qcbcC9SX6P6IEetx30wiBVoyBtBv7r4v64k2vvLNHRIiY85FzYW
RBXNZUAS7YhLVaY0fMMnN82VSDfWUK+1kWlTYogQx8bszgZmKZjmX/6hTDtgZ8za
lLaTmoCJPyOnH1lXllmv8UDKvB6ZJ4CUZdoKmD2akLjvNWM733uMaWIJK6OvtdyA
0hXtPXHgo50s7pGNvXwf4NoDzpKbOzw2+xDoZsS+AMw8VLoYP3DfpHarLeoLq1Jn
aKfhMUxXkz6ZI31ChPtR5VsD1subDjQfjAespXg8qRE1ImUJUHgSwROohhupkruu
aD5GOZFkMkJ+OMPU3eA+63+X95cQZ+Yhr//br3PIPLy9vKX+6eID8jbjH3/lzwp7
Q0SL3sTSOxNCcRPFGg/b7Qs6J45zBCXs2fopJEajKIN4n1Vapn6sdlqO9lhGt+qz
7elZCb4wqeFjWcF9jRI8A9cNbu8kNpsNDyyuc1ba3Gs7BAyIwMeUQxTN0DPh22fl
aVU3Mc1ahJA=
=yj0N
-----END PGP SIGNATURE-----

--=-SCNrsI75jr4h3XEFgGFU--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/