Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbbKZAgq (ORCPT ); Wed, 25 Nov 2015 19:36:46 -0500 Received: from m50-134.163.com ([123.125.50.134]:58874 "EHLO m50-134.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbbKZAgo (ORCPT ); Wed, 25 Nov 2015 19:36:44 -0500 From: Geliang Tang To: Arnd Bergmann , Sekhar Nori , Kevin Hilman , Russell King Cc: Geliang Tang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] ARM: davinci: fix a problematic usage of WARN() Date: Thu, 26 Nov 2015 08:35:27 +0800 Message-Id: X-Mailer: git-send-email 2.5.0 In-Reply-To: <19146462.9tlorCPL8k@wuerfel> X-CM-TRANSID: DtGowEBp2EvTU1ZW0htQAw--.12396S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7Zw4Dtryrury3Kw47uF4kZwb_yoW8ArWfpa yj934vkr47uFyfGFyUZr18Zw1UCanrJw12g345ua18Ww4xuryjv3Wft3WYv3WrGrW8t3yr ZFnIk3Z3XasrZFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UIdgAUUUUU= X-Originating-IP: [116.77.137.90] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiJRa+mVUL8YtyjQAAsP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1878 Lines: 53 WARN() takes a condition and a format string. The condition was omitted. So I added it. Signed-off-by: Geliang Tang --- Changes in v3: - fix kbuild test robot error. Changes in v2: - remove __func__ in WARN() --- arch/arm/mach-davinci/board-dm355-evm.c | 4 +--- arch/arm/mach-davinci/board-dm355-leopard.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c index c71dd99..1844076 100644 --- a/arch/arm/mach-davinci/board-dm355-evm.c +++ b/arch/arm/mach-davinci/board-dm355-evm.c @@ -384,9 +384,7 @@ static __init void dm355_evm_init(void) dm355evm_dm9000_rsrc[2].start = gpio_to_irq(1); aemif = clk_get(&dm355evm_dm9000.dev, "aemif"); - if (IS_ERR(aemif)) - WARN("%s: unable to get AEMIF clock\n", __func__); - else + if (!WARN(IS_ERR(aemif), "unable to get AEMIF clock\n")) clk_prepare_enable(aemif); platform_add_devices(davinci_evm_devices, diff --git a/arch/arm/mach-davinci/board-dm355-leopard.c b/arch/arm/mach-davinci/board-dm355-leopard.c index 680a7a2..284ff27 100644 --- a/arch/arm/mach-davinci/board-dm355-leopard.c +++ b/arch/arm/mach-davinci/board-dm355-leopard.c @@ -242,9 +242,7 @@ static __init void dm355_leopard_init(void) dm355leopard_dm9000_rsrc[2].start = gpio_to_irq(9); aemif = clk_get(&dm355leopard_dm9000.dev, "aemif"); - if (IS_ERR(aemif)) - WARN("%s: unable to get AEMIF clock\n", __func__); - else + if (!WARN(IS_ERR(aemif), "unable to get AEMIF clock\n")) clk_prepare_enable(aemif); platform_add_devices(davinci_leopard_devices, -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/