Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752328AbbKZDRL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Nov 2015 22:17:11 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:16315 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751651AbbKZDRJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Nov 2015 22:17:09 -0500
Message-ID: <56567978.9070104@hisilicon.com>
Date: Thu, 26 Nov 2015 11:16:08 +0800
From: Xinwei Kong <kong.kongxinwei@hisilicon.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Shawn Guo <shawnguo@kernel.org>
CC: <robh+dt@kernel.org>, <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <galak@codeaurora.org>, <catalin.marinas@arm.com>,
        <will.deacon@arm.com>, <tyler.baker@linaro.org>, <arnd@arndb.de>,
        <bintian.wang@huawei.com>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <puck.chen@hisilicon.com>, <liguozhu@hisilicon.com>, <w.f@huawei.com>
Subject: Re: [PATCH 1/1] arm64: dts: add all hi6220 i2c nodes
References: <1448444942-5780-1-git-send-email-kong.kongxinwei@hisilicon.com> <20151125122449.GH11999@tiger>
In-Reply-To: <20151125122449.GH11999@tiger>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.46.34.105]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090203.5656796C.0045,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: e1088cc5564caca4fce353d96a85794e
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2601
Lines: 90

hi Shawn,

On 2015/11/25 20:24, Shawn Guo wrote:
> On Wed, Nov 25, 2015 at 05:49:02PM +0800, Xinwei Kong wrote:
>> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
>> use this I2C IP of Synopsys Designware for HiKey board.
>>
>> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
>> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 37 +++++++++++++++++++++++++++++++
>>  1 file changed, 37 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> index 82d2488..6b591a9 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> @@ -208,5 +208,42 @@
>>  			clock-names = "uartclk", "apb_pclk";
>>  			status = "disabled";
>>  		};
>> +
>> +		i2c0: i2c@f7100000 {
>> +			compatible = "snps,designware-i2c";
>> +			reg = <0x0 0xf7100000 0x0 0x1000>;
>> +			interrupts = <0 44 4>;
>> +			clocks = <&sys_ctrl HI6220_I2C0_CLK>;
>> +			clock-names = "clk_i2c0";
>> +			i2c-sda-hold-time-ns = <300>;
>> +			pinctrl-names = "default";
>> +			pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
>> +			status = "ok";
> 
> Shouldn't it be set "disabled" in <soc>.dtsi and let <board>.dts enable
> it per board design?
> 
> Shawn

get it.

thank you
xinwei
> 
>> +		};
>> +
>> +		i2c1: i2c@f7101000 {
>> +			compatible = "snps,designware-i2c";
>> +			reg = <0x0 0xf7101000 0x0 0x1000>;
>> +			interrupts = <0 45 4>;
>> +			clocks = <&sys_ctrl HI6220_I2C1_CLK>;
>> +			clock-names = "clk_i2c1";
>> +			i2c-sda-hold-time-ns = <300>;
>> +			pinctrl-names = "default";
>> +			pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
>> +			status = "ok";
>> +		};
>> +
>> +		i2c2: i2c@f7102000 {
>> +			compatible = "snps,designware-i2c";
>> +			reg = <0x0 0xf7102000 0x0 0x1000>;
>> +			interrupts = <0 46 4>;
>> +			clocks = <&sys_ctrl HI6220_I2C2_CLK>;
>> +			clock-names = "clk_i2c2";
>> +			i2c-sda-hold-time-ns = <300>;
>> +			pinctrl-names = "default";
>> +			pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
>> +			status = "ok";
>> +		};
>> +
>>  	};
>>  };
>> -- 
>> 1.9.1
>>
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
> 
> .
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/