Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751669AbbKZFED (ORCPT ); Thu, 26 Nov 2015 00:04:03 -0500 Received: from mail-vk0-f43.google.com ([209.85.213.43]:35128 "EHLO mail-vk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbbKZFEA (ORCPT ); Thu, 26 Nov 2015 00:04:00 -0500 MIME-Version: 1.0 In-Reply-To: <20151126015612.GB13138@js1304-P5Q-DELUXE> References: <1448346123-2699-1-git-send-email-iamjoonsoo.kim@lge.com> <20151125120021.GA27342@dhcp22.suse.cz> <20151126015612.GB13138@js1304-P5Q-DELUXE> Date: Thu, 26 Nov 2015 10:33:59 +0530 Message-ID: Subject: Re: [PATCH] mm/vmstat: retrieve more accurate vmstat value From: vinayak menon To: Joonsoo Kim Cc: Michal Hocko , Andrew Morton , linux-kernel@vger.kernel.org, Christoph Lameter , "linux-mm@kvack.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 21 On Thu, Nov 26, 2015 at 7:26 AM, Joonsoo Kim wrote: > On Wed, Nov 25, 2015 at 01:00:22PM +0100, Michal Hocko wrote: >> On Tue 24-11-15 15:22:03, Joonsoo Kim wrote: >> > When I tested compaction in low memory condition, I found that >> > my benchmark is stuck in congestion_wait() at shrink_inactive_list(). >> > This stuck last for 1 sec and after then it can escape. More investigation >> > shows that it is due to stale vmstat value. vmstat is updated every 1 sec >> > so it is stuck for 1 sec. >> >> Wouldn't it be sufficient to use zone_page_state_snapshot in >> too_many_isolated? > This was done by this patch I believe, http://lkml.iu.edu/hypermail/linux/kernel/1501.2/00001.html, though the original issue (wait of more than 1 sec) was fixed by the vmstat changes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/