Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752562AbbKZHcc (ORCPT ); Thu, 26 Nov 2015 02:32:32 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:56224 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbbKZHc3 (ORCPT ); Thu, 26 Nov 2015 02:32:29 -0500 Message-ID: <5656B53B.3080205@huawei.com> Date: Thu, 26 Nov 2015 07:31:07 +0000 From: Salil Mehta User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Yuval Mintz , David Miller , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "paul.gortmaker@windriver.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "arnd@arndb.de" , "liguozhu@hisilicon.com" , "yisen.zhuang@huawei.com" , "dingtianhong@huawei.com" , "zhangfei.gao@linaro.org" , "huangdaode@hisilicon.com" , "kenneth-lee-2012@foxmail.com" , "mehta.salil.lnk@gmail.com" , "xuwei5@hisilicon.com" , "lisheng011@huawei.com" , "devicetree@vger.kernel.org" , linux-kernel , "linux-arm-kernel@lists.infradead.org" , netdev , "linuxarm@huawei.com" Subject: Re: [PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver References: <1447966706-16219-1-git-send-email-salil.mehta@huawei.com> <1447966706-16219-3-git-send-email-salil.mehta@huawei.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.77.177] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.5656B55A.0041,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 1d3953125c9b492db5f3c61a472ce963 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 29 On 11/22/2015 9:30 AM, Yuval Mintz wrote: >> static void hns_ppe_init_hw(struct hns_ppe_cb *ppe_cb) { > ... >> + /* Set default RSS key and indrection table*/ >> + const u32 rss_key[HNS_PPEV2_RSS_KEY_NUM] = { >> + 0x6d5a56da, 0x255b0ec2, >> + 0x4167253d, 0x43a38fb0, >> + 0xd0ca2bcb, 0xae7b30b4, >> + 0x77cb2da3, 0x8030f20c, >> + 0x6a42b73b, 0xbeac01fa, >> + }; >> + >> + /* set default RSS key and remember it */ >> + for (i = 0; i < HNS_PPEV2_RSS_KEY_NUM; i++) >> + ppe_cb->rss_key[i] = rss_key[i]; >> > Is there any reason for the special default key? > Why not use netdev_rss_key_fill()? Thanks for pointing out this. I have incorported this change in latest PATCH V5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/