Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753138AbbKZIeP (ORCPT ); Thu, 26 Nov 2015 03:34:15 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:38711 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752768AbbKZIeO (ORCPT ); Thu, 26 Nov 2015 03:34:14 -0500 Date: Thu, 26 Nov 2015 00:34:12 -0800 From: Christoffer Dall To: Rob Herring Cc: Jin Qian , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Greg Hackmann , Greg Kroah-Hartman , Joe Perches , Dan Carpenter , Peter Senna Tschudin , Alex =?iso-8859-1?Q?Benn=E9e?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] platform: goldfish: pipe: add devicetree bindings Message-ID: <20151126083412.GB14945@lvm> References: <1448481582-16991-1-git-send-email-jinqian@android.com> <20151125202416.GA4636@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151125202416.GA4636@rob-hp-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2126 Lines: 46 On Wed, Nov 25, 2015 at 02:24:16PM -0600, Rob Herring wrote: > On Wed, Nov 25, 2015 at 11:59:37AM -0800, Jin Qian wrote: > > From: Greg Hackmann > > > > Signed-off-by: Greg Hackmann > > (cherry picked from commit 3c56d07eb796066530e93a40e74dea3bc59bf4cf) > > Signed-off-by: Jin Qian > > --- > > Documentation/devicetree/bindings/goldfish/pipe.txt | 17 +++++++++++++++++ > > drivers/platform/goldfish/goldfish_pipe.c | 10 +++++++++- > > 2 files changed, 26 insertions(+), 1 deletion(-) > > create mode 100644 Documentation/devicetree/bindings/goldfish/pipe.txt > > > > diff --git a/Documentation/devicetree/bindings/goldfish/pipe.txt b/Documentation/devicetree/bindings/goldfish/pipe.txt > > new file mode 100644 > > index 0000000..6d3801e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/goldfish/pipe.txt > > @@ -0,0 +1,17 @@ > > +Android Goldfish QEMU Pipe > > + > > +Andorid pipe virtual device generated by android emulator. > > The binding may be trivial, but there's a bigger question of whether > this is the right long term direction. For example is upstream QEMU > going to take all the Android pipe stuff? Couldn't virtio be used here > as the transport? > The Android Pipe is not a very likely candidate for upstream QEMU, no. We are working on a TCG implementation of virtio-vsock (http://qemu-project.org/Features/VirtioVsock) which we think should be a suitable drop-in replacement for the Android pipe. We have yet to measure performance differences between the two, especially in the context of 3D graphics, though. But I wonder if that should really block this from being merged? The support may not be in QEMU but it's in the Android emulator and it would be a less broken implementation with these patches in the kernel than without, I think. -Christoffer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/