Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753366AbbKZJid (ORCPT ); Thu, 26 Nov 2015 04:38:33 -0500 Received: from mail-io0-f169.google.com ([209.85.223.169]:33831 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752869AbbKZJi1 (ORCPT ); Thu, 26 Nov 2015 04:38:27 -0500 MIME-Version: 1.0 X-Originating-IP: [62.219.232.49] In-Reply-To: <1442449758-14594-3-git-send-email-s-anna@ti.com> References: <1442449758-14594-1-git-send-email-s-anna@ti.com> <1442449758-14594-3-git-send-email-s-anna@ti.com> From: Ohad Ben-Cohen Date: Thu, 26 Nov 2015 11:38:06 +0200 Message-ID: Subject: Re: [PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers To: Suman Anna Cc: "Michael S. Tsirkin" , "linux-kernel@vger.kernel.org" , virtualization Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 27 Hi Suman, On Thu, Sep 17, 2015 at 3:29 AM, Suman Anna wrote: > The remoteproc core uses a static ida named rproc_dev_index for > assigning an automatic index number to a registered remoteproc. > The ida core may allocate some internal idr cache layers and ida > bitmap upon any ida allocation, and all these layers are truely > freed only upon the ida destruction. The rproc_dev_index ida is > not destroyed at present, leading to a memory leak when using the > remoteproc core as a module and atleast one rproc device is > registered and unregistered. > > Fix this by invoking ida_destroy() in the remoteproc core module > exit. I saw there was some discussion about this between Michael, James and Tejun whether this should be fixed in the IDA core or not. Has it been resolved? Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/