Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752131AbbKZK1N (ORCPT ); Thu, 26 Nov 2015 05:27:13 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35455 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbbKZK1L (ORCPT ); Thu, 26 Nov 2015 05:27:11 -0500 Date: Thu, 26 Nov 2015 10:27:08 +0000 From: Matt Fleming To: Rasmus Villemoes Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Jones Subject: Re: [PATCH] efi/esrt: don't preformat name Message-ID: <20151126102708.GE2765@codeblueprint.co.uk> References: <1448015417-16712-1-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448015417-16712-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1495 Lines: 47 On Fri, 20 Nov, at 11:30:17AM, Rasmus Villemoes wrote: > kobject_init_and_add takes a format string+args, so there's no reason > to do this formatting in advance. > > Signed-off-by: Rasmus Villemoes > --- > drivers/firmware/efi/esrt.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Looks good to me. Thanks applied! > diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c > index 22c5285f7705..75feb3f5829b 100644 > --- a/drivers/firmware/efi/esrt.c > +++ b/drivers/firmware/efi/esrt.c > @@ -167,14 +167,11 @@ static struct kset *esrt_kset; > static int esre_create_sysfs_entry(void *esre, int entry_num) > { > struct esre_entry *entry; > - char name[20]; > > entry = kzalloc(sizeof(*entry), GFP_KERNEL); > if (!entry) > return -ENOMEM; > > - sprintf(name, "entry%d", entry_num); > - > entry->kobj.kset = esrt_kset; > > if (esrt->fw_resource_version == 1) { > @@ -182,7 +179,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num) > > entry->esre.esre1 = esre; > rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL, > - "%s", name); > + "entry%d", entry_num); > if (rc) { > kfree(entry); > return rc; > -- > 2.6.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/