Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbbKZKhH (ORCPT ); Thu, 26 Nov 2015 05:37:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43880 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbbKZKhE (ORCPT ); Thu, 26 Nov 2015 05:37:04 -0500 Date: Thu, 26 Nov 2015 12:37:00 +0200 From: "Michael S. Tsirkin" To: Ohad Ben-Cohen Cc: Suman Anna , "linux-kernel@vger.kernel.org" , virtualization Subject: Re: [PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers Message-ID: <20151126103700.GA13200@redhat.com> References: <1442449758-14594-1-git-send-email-s-anna@ti.com> <1442449758-14594-3-git-send-email-s-anna@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1303 Lines: 35 On Thu, Nov 26, 2015 at 11:38:06AM +0200, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, Sep 17, 2015 at 3:29 AM, Suman Anna wrote: > > The remoteproc core uses a static ida named rproc_dev_index for > > assigning an automatic index number to a registered remoteproc. > > The ida core may allocate some internal idr cache layers and ida > > bitmap upon any ida allocation, and all these layers are truely > > freed only upon the ida destruction. The rproc_dev_index ida is > > not destroyed at present, leading to a memory leak when using the > > remoteproc core as a module and atleast one rproc device is > > registered and unregistered. > > > > Fix this by invoking ida_destroy() in the remoteproc core module > > exit. > > I saw there was some discussion about this between Michael, James and > Tejun whether this should be fixed in the IDA core or not. > > Has it been resolved? > > Thanks, > Ohad. I don't think we reached any conclusions. I guess I'll merge the virtio patch as-is then. Ohad, would you like to merge 2/2? -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/