Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198AbbKZKoB (ORCPT ); Thu, 26 Nov 2015 05:44:01 -0500 Received: from mx2.suse.de ([195.135.220.15]:55064 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbbKZKn6 (ORCPT ); Thu, 26 Nov 2015 05:43:58 -0500 Subject: Re: [PATCH v2 7/9] mm, page_owner: dump page owner info from dump_page() To: Michal Hocko References: <1448368581-6923-1-git-send-email-vbabka@suse.cz> <1448368581-6923-8-git-send-email-vbabka@suse.cz> <20151125145853.GM27283@dhcp22.suse.cz> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Joonsoo Kim , Minchan Kim , Sasha Levin , "Kirill A. Shutemov" , Mel Gorman From: Vlastimil Babka Message-ID: <5656E26D.1070503@suse.cz> Date: Thu, 26 Nov 2015 11:43:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151125145853.GM27283@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1761 Lines: 64 On 11/25/2015 03:58 PM, Michal Hocko wrote: > Nice! This can be really helpful. > >> Signed-off-by: Vlastimil Babka > > Appart from a typo below, looks good to me > Acked-by: Michal Hocko Thanks! > [...] > >> +void __dump_page_owner(struct page *page) >> +{ >> + struct page_ext *page_ext = lookup_page_ext(page); >> + struct stack_trace trace = { >> + .nr_entries = page_ext->nr_entries, >> + .entries = &page_ext->trace_entries[0], >> + }; >> + gfp_t gfp_mask = page_ext->gfp_mask; >> + int mt = gfpflags_to_migratetype(gfp_mask); >> + >> + if (!test_bit(PAGE_EXT_OWNER, &page_ext->flags)) { >> + pr_alert("page_owner info is not active (free page?)\n"); >> + return; >> + } >> + ; > > Typo? The cat did it! ------8<------ From: Vlastimil Babka Date: Thu, 26 Nov 2015 11:41:11 +0100 Subject: mm, page_owner: dump page owner info from dump_page()-fix Remove stray semicolon. --- mm/page_owner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index a81cfa0c13c3..f4acd2452c35 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -207,7 +207,7 @@ void __dump_page_owner(struct page *page) pr_alert("page_owner info is not active (free page?)\n"); return; } - ; + pr_alert("page allocated via order %u, migratetype %s, gfp_mask 0x%x", page_ext->order, migratetype_names[mt], gfp_mask); dump_gfpflag_names(gfp_mask); -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/