Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751616AbbKZMWh (ORCPT ); Thu, 26 Nov 2015 07:22:37 -0500 Received: from relay.parallels.com ([195.214.232.42]:54627 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbbKZMWf (ORCPT ); Thu, 26 Nov 2015 07:22:35 -0500 Subject: Re: [PATCH v7 0/4] KASAN for arm64 To: Mark Rutland , Catalin Marinas References: <1444665180-301-1-git-send-email-ryabinin.a.a@gmail.com> <20151013083432.GG6320@e104818-lin.cambridge.arm.com> <5649BAFD.6030005@arm.com> <5649F783.40109@gmail.com> <564B40A7.1000206@arm.com> <564B4BFC.1020905@virtuozzo.com> <20151126121007.GC32343@leverpostej> CC: "Suzuki K. Poulose" , Yury , Arnd Bergmann , , Linus Walleij , Ard Biesheuvel , Will Deacon , , kasan-dev , Alexey Klimov , Alexander Potapenko , Dmitry Vyukov , David Keitel , From: Andrey Ryabinin Message-ID: <5656F991.8090108@virtuozzo.com> Date: Thu, 26 Nov 2015 15:22:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151126121007.GC32343@leverpostej> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: US-EXCH.sw.swsoft.com (10.255.249.47) To MSK-EXCH1.sw.swsoft.com (10.67.48.55) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2460 Lines: 68 On 11/26/2015 03:10 PM, Mark Rutland wrote: > Hi Catalin, > > Can you pick up Andrey's patch below for v4.4, until we have a better > solution? > FYI, better solution is almost ready, I'm going to send it today. However, I don't know for sure whether it works or not :) I'm not able to test as I don't have any setup working with 16k pages. > I stumbled across this myself and was about to post a similar patch. > > FWIW: > > Acked-by: Mark Rutland > > Thanks, > Mark. > > On Tue, Nov 17, 2015 at 06:47:08PM +0300, Andrey Ryabinin wrote: >> We should either add proper Kconfig dependency for now, or just make it work. >> >> >> From: Andrey Ryabinin >> Subject: [PATCH] arm64: KASAN depends on !(ARM64_16K_PAGES && ARM64_VA_BITS_48) >> >> On KASAN + 16K_PAGES + 48BIT_VA >> arch/arm64/mm/kasan_init.c: In function ‘kasan_early_init’: >> include/linux/compiler.h:484:38: error: call to ‘__compiletime_assert_95’ declared with attribute error: BUILD_BUG_ON failed: !IS_ALIGNED(KASAN_SHADOW_END, PGDIR_SIZE) >> _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) >> >> Currently KASAN will not work on 16K_PAGES and 48BIT_VA, so >> forbid such configuration to avoid above build failure. >> >> Reported-by: Suzuki K. Poulose >> Signed-off-by: Andrey Ryabinin >> --- >> arch/arm64/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 9ac16a4..bf7de69 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -49,7 +49,7 @@ config ARM64 >> select HAVE_ARCH_AUDITSYSCALL >> select HAVE_ARCH_BITREVERSE >> select HAVE_ARCH_JUMP_LABEL >> - select HAVE_ARCH_KASAN if SPARSEMEM_VMEMMAP >> + select HAVE_ARCH_KASAN if SPARSEMEM_VMEMMAP && !(ARM64_16K_PAGES && ARM64_VA_BITS_48) >> select HAVE_ARCH_KGDB >> select HAVE_ARCH_SECCOMP_FILTER >> select HAVE_ARCH_TRACEHOOK >> -- >> 2.4.10 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/