Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752580AbbKZOwt (ORCPT ); Thu, 26 Nov 2015 09:52:49 -0500 Received: from mail.fireflyinternet.com ([87.106.93.118]:63526 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751226AbbKZOwp (ORCPT ); Thu, 26 Nov 2015 09:52:45 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Thu, 26 Nov 2015 14:52:34 +0000 From: Chris Wilson To: Valentin Rothberg Cc: mingo@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Patrick Plagwitz , Andreas Ziegler , Daniel Lohmann Subject: Re: kernel: stop_machine: report (un)dead code (and feedback request) Message-ID: <20151126145234.GL23362@nuc-i3427.alporthouse.com> References: <20151126144559.GA19758@debian-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151126144559.GA19758@debian-vm> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 30 On Thu, Nov 26, 2015 at 03:45:59PM +0100, Valentin Rothberg wrote: > Hi Chris, > > your commit 4c477de14237 ("kernel: remove stop_machine() Kconfig > dependency") has shown up in today's linux-next tree (20151126). > The commit changes the #ifdef condition in kernel/stop_machine.c > from/to: > > -#if defined(CONFIG_STOP_MACHINE) && defined(CONFIG_SMP) > +#if defined(CONFIG_SMP) || defined(CONFIG_HOTPLUG_CPU) > > Although this change fixes certain configs on X86, the condition now is > a tautology since CONFIG_SMP is already required to compile the file: > > kernel/Makefile:65:obj-$(CONFIG_SMP) += stop_machine.o > > AFAIU, we can safely remove this #ifdef? That seems logical. The argument in favour of it would be to keep the ifdeffery around the function defintion the same as the function declaration in stop_machine.h. -Chris -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/