Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752590AbbKZPN7 (ORCPT ); Thu, 26 Nov 2015 10:13:59 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35982 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016AbbKZPN4 (ORCPT ); Thu, 26 Nov 2015 10:13:56 -0500 MIME-Version: 1.0 In-Reply-To: References: <1448109431-10459-1-git-send-email-e.velds@gmail.com> Date: Thu, 26 Nov 2015 16:13:55 +0100 Message-ID: Subject: Re: [PATCH 0/2] HID: Force feedback support for the Logitech G920 Wheel From: Benjamin Tissoires To: Jiri Kosina Cc: Edwin Velds , Simon Wood , linux-input , "linux-kernel@vger.kernel.org" , =?UTF-8?B?TWljaGFsIE1hbMO9?= , elias vanderstuyft , Benjamin Tissoires , Dmitry Torokhov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 30 On Thu, Nov 26, 2015 at 3:42 PM, Jiri Kosina wrote: > On Sat, 21 Nov 2015, Edwin Velds wrote: > >> This patch implements force feedback support for the Logitech G920 Driving Force >> Racing Wheel. >> >> This patch is based on the basic G920 support patch by Simon Wood: >> http://www.spinics.net/lists/linux-input/msg42174.html > > Simon, it'd be nice if I could get your Tested-by: / Reviewed-by: for > this. > Talking about it, I am not a big fan of renaming hid-logitech-hidpp.c into hid-logitech-hidpp-base.c. This will just break history for no reasons. We could keep it named like that and just add the ff module later. The other question is why do we need to have the ff module in a separate file? We generally try to keep the number of file to a small number, and I am not sure we need to split this for ff only. I am open to any position in favor of splitting, I am just asking. Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/