Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752682AbbKZPli (ORCPT ); Thu, 26 Nov 2015 10:41:38 -0500 Received: from smtprelay.synopsys.com ([198.182.47.9]:42229 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbbKZPlf (ORCPT ); Thu, 26 Nov 2015 10:41:35 -0500 Subject: Re: [PATCH 2/2] PCI support added to ARC To: Bjorn Helgaas , Vineet Gupta References: <9b80d6c1db4d7e2b5ee5dc0056a3d8284e7c2b9b.1448375184.git.jpinto@synopsys.com> <20151125164636.GB1380@localhost> CC: Joao Pinto , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , Carlos Palminha , Alexey Brodkin , arcml , Arnd Bergmann From: Joao Pinto Message-ID: <56572829.4090102@synopsys.com> Date: Thu, 26 Nov 2015 15:41:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151125164636.GB1380@localhost> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.13.184.19] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 884 Lines: 26 Hi Bjorn, On 11/25/2015 4:46 PM, Bjorn Helgaas wrote: > On Wed, Nov 25, 2015 at 05:25:37AM +0000, Vineet Gupta wrote: >> On Tuesday 24 November 2015 08:02 PM, Joao Pinto wrote: > >>> + pr_err("PCI: Device %s not available because"/ >>> + " of resource collisions\n", pci_name(dev)); >> >> Better not to break strings - even if they sometime exceed line sz limit of 80. >> You could anyways reduce the string content herer. > > Also use dev_err() instead of pr_err(). > Thanks for the review. Could you please check PATCH 1/2 regarding the new platform driver? This way I would produce a v2 of the patch set. Thanks, Joao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/