Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752773AbbKZQBb (ORCPT ); Thu, 26 Nov 2015 11:01:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49303 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379AbbKZQB3 convert rfc822-to-8bit (ORCPT ); Thu, 26 Nov 2015 11:01:29 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <7976.1448552129@warthog.procyon.org.uk> References: <7976.1448552129@warthog.procyon.org.uk> <20151124195256.GB3482@thunk.org> <20151120145422.18930.72662.stgit@warthog.procyon.org.uk> <20151120145447.18930.5308.stgit@warthog.procyon.org.uk> To: "Theodore Ts'o" Cc: dhowells@redhat.com, arnd@arndb.de, linux-afs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 02/12] statx: Provide IOC flags for Windows fs attributes MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22522.1448553683.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Thu, 26 Nov 2015 16:01:23 +0000 Message-ID: <22523.1448553683@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1337 Lines: 28 David Howells wrote: > > As a result, I would suggest that we not try to use the > > FS_IOC_[GS]ETFLAGS number scheme for any new interface, so we're at > > least not making a bad situation worse. > > > > The only reason why some other file systems have chosen to use > > FS_IOC_[GS]ETFLAGS, instead of defining their own ioctl, is so they > > can use lsattr/chattr from e2fsprogs instead of creating their own > > utility. But for statx, there isn't a good reason use the same flags > > number space. At the very least, can we use a new flags field for the > > Windows file attributes? It's not like lsattr/chattr has the ability > > to set those flags today anyway. So we might as well use a new flags > > field and a new flags numberspace for them. > > Hmmm... I was trying to make it so that these bits would be saved to disk as > part of the IOC flags so that Samba could make use of them. I guess they'll > have to be stored in an xattr instead. Or as Dave Chinner suggested, I can put them elsewhere and let the FS deal with them in its own way. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/