Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752870AbbKZQUu (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Nov 2015 11:20:50 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:17860 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751931AbbKZQUr convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Nov 2015 11:20:47 -0500
User-Agent: K-9 Mail for Android
In-Reply-To: <5656B00E.6070303@oracle.com>
References: <1447470739-18136-1-git-send-email-bob.liu@oracle.com> <20151125192507.GD19188@x230.dumpdata.com> <20151125205603.GB20267@x230.dumpdata.com> <20151125221234.GA22905@x230.dumpdata.com> <56566E3A.2010205@oracle.com> <20151126024320.GA3130@localhost.localdomain> <5656B00E.6070303@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [PATCH v5 00/10] xen-block: multi hardware-queues/rings support
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date: Thu, 26 Nov 2015 11:20:33 -0500
To: Bob Liu <bob.liu@oracle.com>
CC: xen-devel@lists.xen.org, linux-kernel@vger.kernel.org,
        roger.pau@citrix.com, felipe.franciosi@citrix.com, axboe@fb.com,
        avanzini.arianna@gmail.com, rafal.mielniczuk@citrix.com,
        jonathan.davies@citrix.com, david.vrabel@citrix.com
Message-ID: <31C5E2DC-71DB-40A6-A666-45160171419C@oracle.com>
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2600
Lines: 84

On November 26, 2015 2:09:02 AM EST, Bob Liu <bob.liu@oracle.com> wrote:
>
>On 11/26/2015 10:57 AM, Konrad Rzeszutek Wilk wrote:
>> On Thu, Nov 26, 2015 at 10:28:10AM +0800, Bob Liu wrote:
>>>
>>> On 11/26/2015 06:12 AM, Konrad Rzeszutek Wilk wrote:
>>>> On Wed, Nov 25, 2015 at 03:56:03PM -0500, Konrad Rzeszutek Wilk
>wrote:
>>>>> On Wed, Nov 25, 2015 at 02:25:07PM -0500, Konrad Rzeszutek Wilk
>wrote:
>>>>>>>   xen/blkback: separate ring information out of struct xen_blkif
>>>>>>>   xen/blkback: pseudo support for multi hardware queues/rings
>>>>>>>   xen/blkback: get the number of hardware queues/rings from
>blkfront
>>>>>>>   xen/blkback: make pool of persistent grants and free pages
>per-queue
>>>>>>
>>>>>> OK, got to those as well. I have put them in 'devel/for-jens-4.5'
>and
>>>>>> are going to test them overnight before pushing them out.
>>>>>>
>>>>>> I see two bugs in the code that we MUST deal with:
>>>>>>
>>>>>>  - print_stats () is going to show zero values.
>>>>>>  - the sysfs code (VBD_SHOW) aren't converted over to fetch data
>>>>>>    from all the rings.
>>>>>
>>>>> - kthread_run can't handle the two "name, i" arguments. I see:
>>>>>
>>>>> root      5101     2  0 20:47 ?        00:00:00 [blkback.3.xvda-]
>>>>> root      5102     2  0 20:47 ?        00:00:00 [blkback.3.xvda-]
>>>>
>>>> And doing save/restore:
>>>>
>>>> xl save <id> /tmp/A;
>>>> xl restore /tmp/A;
>>>>
>>>> ends up us loosing the proper state and not getting the ring setup
>back.
>>>> I see this is backend:
>>>>
>>>> [ 2719.448600] vbd vbd-22-51712: -1 guest requested 0 queues,
>exceeding the maximum of 3.
>>>>
>>>> And XenStore agrees:
>>>> tool = ""
>>>>  xenstored = ""
>>>> local = ""
>>>>  domain = ""
>>>>   0 = ""
>>>>    domid = "0"
>>>>    name = "Domain-0"
>>>>    device-model = ""
>>>>     0 = ""
>>>>      state = "running"
>>>>    error = ""
>>>>     backend = ""
>>>>      vbd = ""
>>>>       2 = ""
>>>>        51712 = ""
>>>>         error = "-1 guest requested 0 queues, exceeding the maximum
>of 3."
>>>>
>>>> .. which also leads to a memory leak as xen_blkbk_remove never gets
>>>> called.
>>>
>>> I think which was already fix by your patch:
>>> [PATCH RFC 2/2] xen/blkback: Free resources if connect_ring failed.
>> 
>> Nope. I get that with or without the patch.
>> 
>
>Attached patch should fix this issue. 

Yup!

Thanks!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/