MIME-Version: 1.0
In-Reply-To: <87k2p67wqz.fsf@free-electrons.com>
References: <1448178839-3541-1-git-send-email-mw@semihalf.com>
	<1448178839-3541-5-git-send-email-mw@semihalf.com>
	<87k2p67wqz.fsf@free-electrons.com>
Date: Thu, 26 Nov 2015 18:39:28 +0100
Message-ID: <CAPv3WKdT2WFQy_UksaoRMpd7hwUMAgDXz3sVRjNggEUagyjCxQ@mail.gmail.com>
Subject: Re: [PATCH 04/13] net: mvneta: enable suspend/resume support
From: Marcin Wojtas <mw@semihalf.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: linux-kernel@vger.kernel.org,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Simon Guinot <simon.guinot@sequanux.org>, nadavh@marvell.com,
        Lior Amsalem <alior@marvell.com>, Evan Wang <xswang@marvell.com>,
        Yair Mahalalel <myair@marvell.com>, nitroshift@yahoo.com,
        Grzegorz Jaszczyk <jaz@semihalf.com>, Tomasz Nowicki <tn@semihalf.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 563
Lines: 23

Hi Gregory,


>> +     /* Reset link status */
>> +     pp->link = 0;
>> +     pp->duplex = -1;
>> +     pp->speed = 0;
>> +
>
> Would it be possible to add a kind of mvneta_port_power_down(pp,
> pp->phy_interface) here ? It would allow to save power in standby mode
> too.
>

Sure, I'll try it.

Best regards,
Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/