Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321AbbKZSZd (ORCPT ); Thu, 26 Nov 2015 13:25:33 -0500 Received: from down.free-electrons.com ([37.187.137.238]:46315 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752826AbbKZSZa (ORCPT ); Thu, 26 Nov 2015 13:25:30 -0500 Date: Thu, 26 Nov 2015 19:25:22 +0100 From: Thomas Petazzoni To: Marcin Wojtas Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, davem@davemloft.net, linux@arm.linux.org.uk, sebastian.hesselbarth@gmail.com, andrew@lunn.ch, jason@lakedaemon.net, gregory.clement@free-electrons.com, simon.guinot@sequanux.org, nadavh@marvell.com, alior@marvell.com, xswang@marvell.com, myair@marvell.com, nitroshift@yahoo.com, jaz@semihalf.com, tn@semihalf.com, Subject: Re: [PATCH v2 net 1/6] net: mvneta: add configuration for MBUS windows access protection Message-ID: <20151126192522.25b297ec@free-electrons.com> In-Reply-To: <1448561293-16431-2-git-send-email-mw@semihalf.com> References: <1448561293-16431-1-git-send-email-mw@semihalf.com> <1448561293-16431-2-git-send-email-mw@semihalf.com> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2234 Lines: 60 Marcin, On Thu, 26 Nov 2015 19:08:08 +0100, Marcin Wojtas wrote: > This commit adds missing configuration of MBUS windows access protection > in mvneta_conf_mbus_windows function - a dedicated variable for that > purpose remained there unused since v3.8 initial mvneta support. Because > of that the register contents were inherited from the bootloader. > > Signed-off-by: Marcin Wojtas > Reviewed-by: Gregory CLEMENT > Cc: # v3.8+ > Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network > unit") Is this actually fixing a user visible problem? If not, then I am not sure it qualifies for stable. > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index e84c7f2..c4327b9 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -62,6 +62,7 @@ > #define MVNETA_WIN_SIZE(w) (0x2204 + ((w) << 3)) > #define MVNETA_WIN_REMAP(w) (0x2280 + ((w) << 2)) > #define MVNETA_BASE_ADDR_ENABLE 0x2290 > +#define MVNETA_ACCESS_PROTECT_ENABLE 0x2294 Spaces are used for indentation in the definitions of all other constants in this driver, so I think you should stick with this convention, at least to remain consistent. > #define MVNETA_PORT_CONFIG 0x2400 > #define MVNETA_UNI_PROMISC_MODE BIT(0) > #define MVNETA_DEF_RXQ(q) ((q) << 1) > @@ -3188,9 +3189,11 @@ static void mvneta_conf_mbus_windows(struct mvneta_port *pp, > > win_enable &= ~(1 << i); > win_protect |= 3 << (2 * i); > + Unneeded change. > } > > mvreg_write(pp, MVNETA_BASE_ADDR_ENABLE, win_enable); > + mvreg_write(pp, MVNETA_ACCESS_PROTECT_ENABLE, win_protect); > } Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/