Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbbKZSby (ORCPT ); Thu, 26 Nov 2015 13:31:54 -0500 Received: from mail-ob0-f169.google.com ([209.85.214.169]:33198 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752867AbbKZSbv (ORCPT ); Thu, 26 Nov 2015 13:31:51 -0500 MIME-Version: 1.0 In-Reply-To: <20151126192522.25b297ec@free-electrons.com> References: <1448561293-16431-1-git-send-email-mw@semihalf.com> <1448561293-16431-2-git-send-email-mw@semihalf.com> <20151126192522.25b297ec@free-electrons.com> Date: Thu, 26 Nov 2015 19:31:51 +0100 Message-ID: Subject: Re: [PATCH v2 net 1/6] net: mvneta: add configuration for MBUS windows access protection From: Marcin Wojtas To: Thomas Petazzoni Cc: linux-kernel@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , netdev@vger.kernel.org, "David S. Miller" , Russell King - ARM Linux , Sebastian Hesselbarth , Andrew Lunn , Jason Cooper , =?UTF-8?Q?Gregory_Cl=C3=A9ment?= , Simon Guinot , nadavh@marvell.com, Lior Amsalem , Evan Wang , Yair Mahalalel , nitroshift@yahoo.com, Grzegorz Jaszczyk , Tomasz Nowicki , "stable@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2470 Lines: 66 Hi Thomas, 2015-11-26 19:25 GMT+01:00 Thomas Petazzoni : > Marcin, > > On Thu, 26 Nov 2015 19:08:08 +0100, Marcin Wojtas wrote: >> This commit adds missing configuration of MBUS windows access protection >> in mvneta_conf_mbus_windows function - a dedicated variable for that >> purpose remained there unused since v3.8 initial mvneta support. Because >> of that the register contents were inherited from the bootloader. >> >> Signed-off-by: Marcin Wojtas >> Reviewed-by: Gregory CLEMENT >> Cc: # v3.8+ >> Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network >> unit") > > Is this actually fixing a user visible problem? If not, then I am not > sure it qualifies for stable. Indeed, it's not fixing a visible thing, unless you resume from suspend to ram. However, the original driver declares and updates 'win_protect ' variable, which have remained unused for past 3 years:) If you think it's not worth cc'ing stable despite that, I will remove the notification. > >> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c >> index e84c7f2..c4327b9 100644 >> --- a/drivers/net/ethernet/marvell/mvneta.c >> +++ b/drivers/net/ethernet/marvell/mvneta.c >> @@ -62,6 +62,7 @@ >> #define MVNETA_WIN_SIZE(w) (0x2204 + ((w) << 3)) >> #define MVNETA_WIN_REMAP(w) (0x2280 + ((w) << 2)) >> #define MVNETA_BASE_ADDR_ENABLE 0x2290 >> +#define MVNETA_ACCESS_PROTECT_ENABLE 0x2294 > > Spaces are used for indentation in the definitions of all other > constants in this driver, so I think you should stick with this > convention, at least to remain consistent. > Ok. >> #define MVNETA_PORT_CONFIG 0x2400 >> #define MVNETA_UNI_PROMISC_MODE BIT(0) >> #define MVNETA_DEF_RXQ(q) ((q) << 1) >> @@ -3188,9 +3189,11 @@ static void mvneta_conf_mbus_windows(struct mvneta_port *pp, >> >> win_enable &= ~(1 << i); >> win_protect |= 3 << (2 * i); >> + > > Unneeded change. > Indeed, my mistake. Thanks, Marcin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/