Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751360AbbK0GiF (ORCPT ); Fri, 27 Nov 2015 01:38:05 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36228 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbbK0GiD (ORCPT ); Fri, 27 Nov 2015 01:38:03 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.0 \(3094\)) Subject: Re: [PATCH] scripts: fix the sys path for gdb scripts From: yalin wang In-Reply-To: <56556592.3050008@siemens.com> Date: Fri, 27 Nov 2015 14:37:55 +0800 Cc: linux-kernel@vger.kernel.org, Andrew Morton Content-Transfer-Encoding: 7bit Message-Id: <306FDB9E-EECA-4171-BD9F-58FF827730BD@gmail.com> References: <1447930457-30865-1-git-send-email-yalin.wang2010@gmail.com> <56556592.3050008@siemens.com> To: Jan Kiszka X-Mailer: Apple Mail (2.3094) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1516 Lines: 47 > On Nov 25, 2015, at 15:38, Jan Kiszka wrote: > > On 2015-11-19 11:54, yalin wang wrote: >> The sys.path should be scripts/gdb, >> so that we can import linux lib correctly. >> >> Signed-off-by: yalin wang >> --- >> scripts/gdb/vmlinux-gdb.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/gdb/vmlinux-gdb.py b/scripts/gdb/vmlinux-gdb.py >> index ce82bf5..5a45d1a 100644 >> --- a/scripts/gdb/vmlinux-gdb.py >> +++ b/scripts/gdb/vmlinux-gdb.py >> @@ -13,7 +13,7 @@ >> >> import os >> >> -sys.path.insert(0, os.path.dirname(__file__) + "/scripts/gdb") >> +sys.path.insert(0, os.path.dirname(__file__)) >> >> try: >> gdb.parse_and_eval("0") >> > > NACK. This patch is assuming that vmlinux-gdb.py is (only) started from > the scripts/gdb folder. But CONFIG_GDB_SCRIPTS places a link to > vmlinux-gdb.py aside the vmlinux binary in the top-level folder. That > way, the script is auto-loaded by gdb. > > If you have a compelling use case for loading the script manually from > its original folder, we can discuss augmenting the path. But removing > the existing one is wrong. > > Andrew, please drop the patch from your queue. > ok, i will send a V2 patch for this . -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/