Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754064AbbK0If5 (ORCPT ); Fri, 27 Nov 2015 03:35:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48578 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751504AbbK0If4 (ORCPT ); Fri, 27 Nov 2015 03:35:56 -0500 From: Minfei Huang To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, mhuang@redhat.com, Minfei Huang Subject: [PATCH] blk-mg-tag: Make tag's codeflow more reasonably during initializing Date: Fri, 27 Nov 2015 16:37:48 +0800 Message-Id: <1448613468-11708-1-git-send-email-mhuang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2325 Lines: 79 From: Minfei Huang It might be more reasonable to cleanup all of the allocations in same function, if there is a fatal. Thus we can make function more independency to export it. For this patch, variant tag will be allocated in blk_mq_init_tags, and it will be freed in same function, if there is an error during initializing the tag. What the blk_mq_init_bitmap_tags does is to allocate bitmap. Signed-off-by: Minfei Huang --- block/blk-mq-tag.c | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index a07ca34..7a1d9a8 100644 --- a/block/blk-mq-tag.c +++ b/block/blk-mq-tag.c @@ -596,23 +596,24 @@ static void bt_free(struct blk_mq_bitmap_tags *bt) kfree(bt->bs); } -static struct blk_mq_tags *blk_mq_init_bitmap_tags(struct blk_mq_tags *tags, - int node, int alloc_policy) +static int blk_mq_init_bitmap_tags(struct blk_mq_tags *tags, + int node, int alloc_policy) { + int ret = 0; unsigned int depth = tags->nr_tags - tags->nr_reserved_tags; tags->alloc_policy = alloc_policy; - if (bt_alloc(&tags->bitmap_tags, depth, node, false)) - goto enomem; - if (bt_alloc(&tags->breserved_tags, tags->nr_reserved_tags, node, true)) - goto enomem; + ret = bt_alloc(&tags->bitmap_tags, depth, node, false); + if (ret) + goto out; - return tags; -enomem: - bt_free(&tags->bitmap_tags); - kfree(tags); - return NULL; + ret = bt_alloc(&tags->breserved_tags, + tags->nr_reserved_tags, node, true); + if (ret) + bt_free(&tags->bitmap_tags); +out: + return ret; } struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags, @@ -638,7 +639,12 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags, tags->nr_tags = total_tags; tags->nr_reserved_tags = reserved_tags; - return blk_mq_init_bitmap_tags(tags, node, alloc_policy); + if (blk_mq_init_bitmap_tags(tags, node, alloc_policy)) { + kfree(tags); + return NULL; + } + + return tags; } void blk_mq_free_tags(struct blk_mq_tags *tags) -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/